public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: Shenglei Zhang <shenglei.zhang@intel.com>, devel@edk2.groups.io
Cc: Siyuan Fu <siyuan.fu@intel.com>, Jiaxin Wu <jiaxin.wu@intel.com>
Subject: Re: [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement
Date: Wed, 20 May 2020 11:03:56 +0200	[thread overview]
Message-ID: <dd4f9dc6-bad4-abe8-0b2c-3dba17ffbcb7@linux.intel.com> (raw)
In-Reply-To: <20200520030847.11416-1-shenglei.zhang@intel.com>

Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>

On 20-May-20 05:08, Shenglei Zhang wrote:
> The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is
> meaningless if Index = 0. So checking 'Index != 0' should be
> performed first in the if statement.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>
> v2: Update 'Index > 0' to 'Index != 0'
>
>   NetworkPkg/Library/DxeNetLib/NetBuffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/NetworkPkg/Library/DxeNetLib/NetBuffer.c b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
> index a232802c9a21..329a17623d94 100644
> --- a/NetworkPkg/Library/DxeNetLib/NetBuffer.c
> +++ b/NetworkPkg/Library/DxeNetLib/NetBuffer.c
> @@ -1063,7 +1063,7 @@ NetbufAllocSpace (
>       } else {
>         NetbufGetByte (Nbuf, 0, &Index);
>   
> -      if ((NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len) && (Index > 0)) {
> +      if ((Index != 0) && (NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len)) {
>           Index--;
>         }
>       }


  reply	other threads:[~2020-05-20  9:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  3:08 [PATCH v2] NetworkPkg/DxeNetLib: Change the order of conditions in IF statement Zhang, Shenglei
2020-05-20  9:03 ` Maciej Rabeda [this message]
2020-05-20 11:41 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-05-20 12:48   ` Maciej Rabeda
  -- strict thread matches above, loose matches on Subject: below --
2020-05-20  2:33 Zhang, Shenglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd4f9dc6-bad4-abe8-0b2c-3dba17ffbcb7@linux.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox