* Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting
[not found] <175382D424388526.3578@groups.io>
@ 2023-04-11 18:06 ` Rebecca Cran
2023-04-11 20:14 ` Michael D Kinney
0 siblings, 1 reply; 2+ messages in thread
From: Rebecca Cran @ 2023-04-11 18:06 UTC (permalink / raw)
To: devel, Liming Gao, Bob Feng, Yuwei Chen, Michael D Kinney
Could I get some reviews on this please?
--
Rebecca Cran
On 4/6/23 7:28 PM, Rebecca Cran wrote:
> To help people format patches with the correct options, add an alias
> named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
> --stat-graph-width=20'.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> BaseTools/Scripts/SetupGit.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> index 91814199bfb9..5f93124967bf 100644
> --- a/BaseTools/Scripts/SetupGit.py
> +++ b/BaseTools/Scripts/SetupGit.py
> @@ -57,6 +57,8 @@ MIN_GIT_VERSION = (1, 9, 0)
>
> # Set of options to be set identically for all repositories
> OPTIONS = [
> + {'section': 'alias', 'option': 'fp',
> + 'value': 'format-patch -M --stat=1000 --stat-graph-width=20'},
> {'section': 'am', 'option': 'keepcr', 'value': True},
> {'section': 'am', 'option': 'signoff', 'value': True},
> {'section': 'cherry-pick', 'option': 'signoff', 'value': True},
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting
2023-04-11 18:06 ` [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting Rebecca Cran
@ 2023-04-11 20:14 ` Michael D Kinney
0 siblings, 0 replies; 2+ messages in thread
From: Michael D Kinney @ 2023-04-11 20:14 UTC (permalink / raw)
To: Rebecca Cran, devel@edk2.groups.io, Gao, Liming, Feng, Bob C,
Chen, Christine
Cc: Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, April 11, 2023 11:06 AM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine
> <yuwei.chen@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting
>
> Could I get some reviews on this please?
>
>
> --
>
> Rebecca Cran
>
>
>
> On 4/6/23 7:28 PM, Rebecca Cran wrote:
> > To help people format patches with the correct options, add an alias
> > named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
> > --stat-graph-width=20'.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> > BaseTools/Scripts/SetupGit.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> > index 91814199bfb9..5f93124967bf 100644
> > --- a/BaseTools/Scripts/SetupGit.py
> > +++ b/BaseTools/Scripts/SetupGit.py
> > @@ -57,6 +57,8 @@ MIN_GIT_VERSION = (1, 9, 0)
> >
> > # Set of options to be set identically for all repositories
> > OPTIONS = [
> > + {'section': 'alias', 'option': 'fp',
> > + 'value': 'format-patch -M --stat=1000 --stat-graph-width=20'},
> > {'section': 'am', 'option': 'keepcr', 'value': True},
> > {'section': 'am', 'option': 'signoff', 'value': True},
> > {'section': 'cherry-pick', 'option': 'signoff', 'value': True},
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-11 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <175382D424388526.3578@groups.io>
2023-04-11 18:06 ` [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting Rebecca Cran
2023-04-11 20:14 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox