From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx.groups.io with SMTP id smtpd.web10.21768.1681236362077986286 for ; Tue, 11 Apr 2023 11:06:02 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=sV12Y52W; spf=pass (domain: bsdio.com, ip: 66.111.4.25, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 690165C0182; Tue, 11 Apr 2023 14:06:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 11 Apr 2023 14:06:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681236361; x=1681322761; bh=QnWq6VLvtcM06iAWCtHNyWlVxA818vpi3Bt ZHcYIXmY=; b=sV12Y52WR2sxNAqbfN67MHWJyAbC+l1q2iRR7/pROGOe8NE2wcV wMOEZNeVMeHb7shizgzF0pCwhP+q4HCZciresk4fXrTrCsEezpf9YZd7kl7drQg0 5h0gLnBGt3jBZZR8GGCuOg3ooVQ48+zWkn9pGmdPZor2ms6f7X9mS6nw1eEnz+TE IwrtaErQlA9MQQ/f0C3q8ZzXVygMqwwV/+Gx6L5XDrI88s3torsYADIDC6039Q3z J11Flvrt568hXYZmSuf+/LWjD0lMmAvLKkaVzdM2iel/1FtOObvELQ15SpaHW0xr 2Lz5uOAx+DRlPSJIykoQtr1q3wC6MtgHvGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1681236361; x= 1681322761; bh=QnWq6VLvtcM06iAWCtHNyWlVxA818vpi3BtZHcYIXmY=; b=J eIuEPw9TTUpyim0URtS0sf+xYHeVMssSiNOg7CBDeHYoVvjs5lyUbv3jDgNlhITR C0MPAq5Mu/avlHhstN+uaIjB6iXMPBDkjbgT9XwYSXkncTTnO+AkAFQNc4gEPqQB ZH+huIOYhG1YuOCRlj9uLKhrrw0FgqSE+z38H/4XcnRZoRIjJBSIEW2emApgVS+Y 7Q9Gs2g+0v2p9NYBu8+ab0clek1JXgYVrKOJXF/EZplUv3agI8Ad8TwDcAD52dlz 5xx4D1E28UdjrK2/Ll0ht3fI0oZaiG4lj1TPJce0nIn+wyXjCrVg/ypc4srr6r7J 1W4mLRf3BkY1ZnJSEEJsQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeeludevtdeltdevvdeuudegueduieeitdeuuddvffeukeefjeffuddvteej veffvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 Apr 2023 14:06:00 -0400 (EDT) Message-ID: Date: Tue, 11 Apr 2023 12:06:00 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting To: devel@edk2.groups.io, Liming Gao , Bob Feng , Yuwei Chen , Michael D Kinney References: <175382D424388526.3578@groups.io> From: "Rebecca Cran" In-Reply-To: <175382D424388526.3578@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Could I get some reviews on this please? -- Rebecca Cran On 4/6/23 7:28 PM, Rebecca Cran wrote: > To help people format patches with the correct options, add an alias > named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000 > --stat-graph-width=20'. > > Signed-off-by: Rebecca Cran > --- > BaseTools/Scripts/SetupGit.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py > index 91814199bfb9..5f93124967bf 100644 > --- a/BaseTools/Scripts/SetupGit.py > +++ b/BaseTools/Scripts/SetupGit.py > @@ -57,6 +57,8 @@ MIN_GIT_VERSION = (1, 9, 0) > > # Set of options to be set identically for all repositories > OPTIONS = [ > + {'section': 'alias', 'option': 'fp', > + 'value': 'format-patch -M --stat=1000 --stat-graph-width=20'}, > {'section': 'am', 'option': 'keepcr', 'value': True}, > {'section': 'am', 'option': 'signoff', 'value': True}, > {'section': 'cherry-pick', 'option': 'signoff', 'value': True},