Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting

[Rebecca Cran]

Could I get some reviews on this please?


-- 

Rebecca Cran



On 4/6/23 7:28 PM, Rebecca Cran wrote:
> To help people format patches with the correct options, add an alias
> named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
> --stat-graph-width=20'.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>   BaseTools/Scripts/SetupGit.py | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> index 91814199bfb9..5f93124967bf 100644
> --- a/BaseTools/Scripts/SetupGit.py
> +++ b/BaseTools/Scripts/SetupGit.py
> @@ -57,6 +57,8 @@ MIN_GIT_VERSION = (1, 9, 0)
>   
>   # Set of options to be set identically for all repositories
>   OPTIONS = [
> +    {'section': 'alias',       'option': 'fp',
> +     'value': 'format-patch -M --stat=1000 --stat-graph-width=20'},
>       {'section': 'am',          'option': 'keepcr',            'value': True},
>       {'section': 'am',          'option': 'signoff',           'value': True},
>       {'section': 'cherry-pick', 'option': 'signoff',           'value': True},

Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Tuesday, April 11, 2023 11:06 AM
> To: devel@edk2.groups.io; Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>; Chen, Christine
> <yuwei.chen@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update SetupGit.py to add new 'fp' alias for patch formatting
> 
> Could I get some reviews on this please?
> 
> 
> --
> 
> Rebecca Cran
> 
> 
> 
> On 4/6/23 7:28 PM, Rebecca Cran wrote:
> > To help people format patches with the correct options, add an alias
> > named 'fp' to SetupGit.py that runs format-patch with '-M --stat=1000
> > --stat-graph-width=20'.
> >
> > Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> > ---
> >   BaseTools/Scripts/SetupGit.py | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py
> > index 91814199bfb9..5f93124967bf 100644
> > --- a/BaseTools/Scripts/SetupGit.py
> > +++ b/BaseTools/Scripts/SetupGit.py
> > @@ -57,6 +57,8 @@ MIN_GIT_VERSION = (1, 9, 0)
> >
> >   # Set of options to be set identically for all repositories
> >   OPTIONS = [
> > +    {'section': 'alias',       'option': 'fp',
> > +     'value': 'format-patch -M --stat=1000 --stat-graph-width=20'},
> >       {'section': 'am',          'option': 'keepcr',            'value': True},
> >       {'section': 'am',          'option': 'signoff',           'value': True},
> >       {'section': 'cherry-pick', 'option': 'signoff',           'value': True},