From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.278.1652204065852802186 for ; Tue, 10 May 2022 10:34:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@linux.microsoft.com header.s=default header.b=agElHmTg; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id B7B3C20EC9BD; Tue, 10 May 2022 10:34:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B7B3C20EC9BD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1652204065; bh=d0jYGZw2hc106kkmU2jFplNd42VBRf4SRWFa8JfE+as=; h=Date:Subject:From:To:Cc:Reply-To:References:In-Reply-To:From; b=agElHmTgY1etmgS2RkpiPBq8yW06N4i9NdvuvEjPuYY48GzzuiATB74QIuEFLEnX8 RnKC4s5MYXy66CRSxYFyYJsg6YRyCOfeQAjMVddqP16U1Gxzk6zsL09GKHMoim7GiP 1N42PWoXLcLP8yLAeFQjFLfHAUqQVVp0Y27AzEZo= Message-ID: Date: Tue, 10 May 2022 13:34:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 0/3] MinPlatformPkg: Add FADT duty offset and width PCDs From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong , Ankit Sinha Reply-To: devel@edk2.groups.io, mikuback@linux.microsoft.com References: <16E4F328A12CE1E2.27279@groups.io> <5a877d28-27c7-492c-0370-7e7f0f4679e9@linux.microsoft.com> In-Reply-To: <5a877d28-27c7-492c-0370-7e7f0f4679e9@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Another reminder to look at this patch. Thanks, Michael On 4/29/2022 4:07 PM, Michael Kubacki wrote: > Another reminder to merge this series. Chasel has added his review and=20 > that is in this branch: >=20 > https://github.com/makubacki/edk2-platforms/commits/active/add_duty_pcd= s_minplatformpkg_v1_rb1=20 >=20 >=20 > Thanks, > Michael >=20 > On 4/22/2022 10:04 AM, Michael Kubacki wrote: >> Reminder to review this series. >> >> Ankit Sinha has reviewed it but need a maintainer to review and merge. >> >> On 4/11/2022 4:58 PM, Michael Kubacki wrote: >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3543 >>> >>> Adds PCDs to the MinPlatformPkg DEC file so MinPlatformPkg consumers >>> (board packages) can customize the DUTY_OFFSET and DUTY_CYCLE >>> values in their build files. >>> >>> The copy of AcpiPlatform in SimicsOpenBoardPkg is also updated to >>> keep the change in sync with the source MinPlatformPkg module. >>> >>> Cc: Chasel Chiu >>> Cc: Nate DeSimone >>> Cc: Liming Gao >>> Cc: Eric Dong >>> Signed-off-by: Michael Kubacki >>> >>> Michael Kubacki (3): >>> =C2=A0=C2=A0 MinPlatformPkg: Add FADT duty offset and duty width PCDs >>> =C2=A0=C2=A0 MinPlatformPkg/AcpiPlatform: Use FADT duty offset and wi= dth PCDs >>> =C2=A0=C2=A0 SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset an= d width PCDs >>> >>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c |=C2=A0 = 3 +++ >>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c |=C2=A0 4 += +-- >>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.c=20 >>> |=C2=A0 3 +++ >>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa= dt/Fadt.c=20 >>> |=C2=A0 4 ++-- >>> Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf |=C2=A0= 2 ++ >>> Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 15 +++++++++++++++ >>> Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.inf=20 >>> |=C2=A0 2 ++ >>> =C2=A0 7 files changed, 29 insertions(+), 4 deletions(-) >>>