public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pete Batard" <pete@akeo.ie>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	"Leif Lindholm" <leif@nuviainc.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Jeremy Linton" <lintonrjeremy@gmail.com>
Subject: Re: [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub
Date: Sat, 8 Feb 2020 14:13:29 +0000	[thread overview]
Message-ID: <dd6919da-8c8a-37c9-e826-cc2996b947fb@akeo.ie> (raw)
In-Reply-To: <CAKv+Gu92+mZBaFPPcaCsLn2FHq9dme9P92xw790Zt4Kr57058g@mail.gmail.com>

Hi Ard,

On 2020.02.08 08:50, Ard Biesheuvel wrote:
> On Mon, 3 Feb 2020 at 13:14, Pete Batard <pete@akeo.ie> wrote:
>>
>> Changes from v2:
>> * Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check
>>
>> Jeremy Linton (2):
>>    Silicon/Broadcom/Net: Add Genet stub driver to setup MAC
>>    Platform/RPi4: Enable Broadcom Genet stub driver
>>
>> Pete Batard (1):
>>    Platform/RPi: Add PlatformPcdLib to set the Genet MAC address
>>
> 
> For the series,
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> 
> Pushed as 2253a252a61b..3f0d14bb1358

Thanks.


I guess I'll use this opportunity to send another reminder about Jared's 
two liner (who must start to feel desperate to ever see his work 
integrated into platforms) as well as other RPi patches, that came 
before this one, and that I hope are not in the process of falling 
through the cracks...

- https://edk2.groups.io/g/devel/topic/69331625#52611
- https://edk2.groups.io/g/devel/topic/69532223#53028
- https://edk2.groups.io/g/devel/topic/69532224#53029

Regards,

/Pete


> 
> 
>>   Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c   |  45 ++++++++
>>   Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf |  43 ++++++++
>>   Platform/RaspberryPi/RPi4/RPi4.dsc                             |   5 +
>>   Platform/RaspberryPi/RPi4/RPi4.fdf                             |   1 +
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf       |  40 +++++++
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c               | 114 ++++++++++++++++++++
>>   Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h               |  20 ++++
>>   Silicon/Broadcom/Drivers/Net/BcmNet.dec                        |  22 ++++
>>   8 files changed, 290 insertions(+)
>>   create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.c
>>   create mode 100644 Platform/RaspberryPi/Library/PlatformPcdLib/PlatformPcdLib.inf
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.c
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h
>>   create mode 100644 Silicon/Broadcom/Drivers/Net/BcmNet.dec
>>
>> --
>> 2.21.0.windows.1
>>


      reply	other threads:[~2020-02-08 14:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-03 13:13 [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub Pete Batard
2020-02-03 13:13 ` [edk2-platforms][PATCH v3 1/3] Silicon/Broadcom/Net: Add Genet stub driver to setup MAC Pete Batard
2020-02-03 13:13 ` [edk2-platforms][PATCH v3 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address Pete Batard
2020-02-03 13:13 ` [edk2-platforms][PATCH v3 3/3] Platform/RPi4: Enable Broadcom Genet stub driver Pete Batard
2020-02-08  8:50 ` [edk2-platforms][PATCH v3 0/3] Platform/RPi4: Add Genet network driver stub Ard Biesheuvel
2020-02-08 14:13   ` Pete Batard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dd6919da-8c8a-37c9-e826-cc2996b947fb@akeo.ie \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox