From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BCC2E21190716 for ; Tue, 20 Nov 2018 03:17:29 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E65A31524FE; Tue, 20 Nov 2018 11:17:29 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-171.rdu2.redhat.com [10.10.120.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id C18E968B33; Tue, 20 Nov 2018 11:17:27 +0000 (UTC) To: Vijayenthiran Subramaniam , edk2-devel@lists.01.org, star.zeng@intel.com, jian.j.wang@intel.com, ruiyu.ni@intel.com References: <20181120103805.18637-1-vijayenthiran.subramaniam@arm.com> From: Laszlo Ersek Message-ID: Date: Tue, 20 Nov 2018 12:17:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181120103805.18637-1-vijayenthiran.subramaniam@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 20 Nov 2018 11:17:29 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/Variable: add debug logs in VariableServiceSetVariable X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 11:17:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/20/18 11:38, Vijayenthiran Subramaniam wrote: > Print debug messages if size of the VariableName plus DataSize exceeds > Max(Auth|Voltaile)VariableSize bytes. The messages will be useful if any > platform specific value of Max(Auth|Voltaile)VariableSize PCDs have to > be changed. > > Cc: Star Zeng > Cc: Jian J Wang > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Vijayenthiran Subramaniam > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > index 8e8db71bd201..db54fa4412c0 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -3234,14 +3234,20 @@ VariableServiceSetVariable ( > // > if ((Attributes & VARIABLE_ATTRIBUTE_AT_AW) != 0) { > if (StrSize (VariableName) + PayloadSize > mVariableModuleGlobal->MaxAuthVariableSize - GetVariableHeaderSize ()) { > + DEBUG ((DEBUG_ERROR, "%a: Size of (%s) variable + DataSize exceeds MaxAuthVariableSize.\n", > + __FUNCTION__, VariableName)); > return EFI_INVALID_PARAMETER; > } > } else if ((Attributes & EFI_VARIABLE_NON_VOLATILE) != 0) { > if (StrSize (VariableName) + PayloadSize > mVariableModuleGlobal->MaxVariableSize - GetVariableHeaderSize ()) { > + DEBUG ((DEBUG_ERROR, "%a: Size of (%s) variable + DataSize exceeds MaxVariableSize.\n", > + __FUNCTION__, VariableName)); > return EFI_INVALID_PARAMETER; > } > } else { > if (StrSize (VariableName) + PayloadSize > mVariableModuleGlobal->MaxVolatileVariableSize - GetVariableHeaderSize ()) { > + DEBUG ((DEBUG_ERROR, "%a: Size of (%s) variable + DataSize exceeds MaxVolatileVariableSize.\n", > + __FUNCTION__, VariableName)); > return EFI_INVALID_PARAMETER; > } > } > You could make this more useful as well -- again, *if* the package maintainers agree with the new log messages --; namely, the vendor GUID, DataSize, and the limit in question should / could all be logged. Thanks Laszlo