From: Laszlo Ersek <lersek@redhat.com>
To: "Ni, Ruiyu" <ruiyu.ni@Intel.com>,
"Lohr, Paul A" <paul.a.lohr@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs
Date: Tue, 23 Oct 2018 11:43:58 +0200 [thread overview]
Message-ID: <dd80ac15-3b87-61b2-5567-3f9df5f5808a@redhat.com> (raw)
In-Reply-To: <1998f4ff-13e0-3918-db78-74ada10fddc0@Intel.com>
On 10/23/18 11:36, Ni, Ruiyu wrote:
> On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
>> Hello,
>>
>> Code to remove SMRAM = UC (line 650-ish) looks good. I would suggest
>> adding some debug comments in the area it was removed. Thanks.
>
> debug message or comments?
> I guess you'd like to have some comments to say "SMRR is enabled by CPU
> SMM driver so no need to reset the SMRAM to UC in MTRR". Correct?
Such a comment sounds great to me, just please include: "by calling
SmmCpuFeaturesInitializeProcessor from SmmCpuFeaturesLib".
[...]
Thanks!
Laszlo
next prev parent reply other threads:[~2018-10-23 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 9:03 [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs Ruiyu Ni
2018-10-22 14:30 ` Laszlo Ersek
2018-10-23 3:12 ` Lohr, Paul A
2018-10-23 9:36 ` Ni, Ruiyu
2018-10-23 9:43 ` Laszlo Ersek [this message]
2018-10-29 20:33 ` Lohr, Paul A
2018-10-23 9:21 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd80ac15-3b87-61b2-5567-3f9df5f5808a@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox