From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 503782117D288
 for <edk2-devel@lists.01.org>; Tue, 23 Oct 2018 02:44:00 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 5FF9130013D0;
 Tue, 23 Oct 2018 09:44:00 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-214.rdu2.redhat.com
 [10.10.120.214])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 16C075D6AA;
 Tue, 23 Oct 2018 09:43:58 +0000 (UTC)
To: "Ni, Ruiyu" <ruiyu.ni@Intel.com>, "Lohr, Paul A" <paul.a.lohr@intel.com>, 
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
 "Yao, Jiewen" <jiewen.yao@intel.com>
References: <20181022090333.95988-1-ruiyu.ni@intel.com>
 <c3d1c92b-cb9b-a2be-eebe-cf2e2ac83fe5@redhat.com>
 <CDC618B1AC5F1346B65D98DCD05D1028BEE9F90A@fmsmsx118.amr.corp.intel.com>
 <1998f4ff-13e0-3918-db78-74ada10fddc0@Intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <dd80ac15-3b87-61b2-5567-3f9df5f5808a@redhat.com>
Date: Tue, 23 Oct 2018 11:43:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1998f4ff-13e0-3918-db78-74ada10fddc0@Intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.48]); Tue, 23 Oct 2018 09:44:00 +0000 (UTC)
Subject: Re: [PATCH] MdeModulePkg/PiSmmIpl: Do not reset SMRAM to UC when CPU driver runs
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Oct 2018 09:44:01 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 10/23/18 11:36, Ni, Ruiyu wrote:
> On 10/23/2018 11:12 AM, Lohr, Paul A wrote:
>> Hello,
>>
>> Code to remove SMRAM = UC (line 650-ish) looks good.  I would suggest
>> adding some debug comments in the area it was removed.  Thanks.
> 
> debug message or comments?
> I guess you'd like to have some comments to say "SMRR is enabled by CPU
> SMM driver so no need to reset the SMRAM to UC in MTRR". Correct?

Such a comment sounds great to me, just please include: "by calling
SmmCpuFeaturesInitializeProcessor from SmmCpuFeaturesLib".

[...]

Thanks!
Laszlo