From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CC725209831ED for ; Fri, 13 Jul 2018 00:23:28 -0700 (PDT) Received: by mail-pl0-x244.google.com with SMTP id 30-v6so11809977pld.13 for ; Fri, 13 Jul 2018 00:23:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=NfGe5gfXqYijA565WTzU88XJuzltFDiiNaxRmy1oPM0=; b=KQd0bGIuiBsl6HcSfB2WIqoucw7lDDHzB/BGNDclQ9sLUVaCLuLi8tUwOxbvFbEGKl fBKMSX1R3qcMaq8Y8TZyo9CtFSpAPKoYEHU+u0BAlX55Uz9DE8DWu8VrdusCI3MZQlxi 3ypVCeNX94Xw1q1X8FyHuhRuJ7I5LSZSGXWcI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NfGe5gfXqYijA565WTzU88XJuzltFDiiNaxRmy1oPM0=; b=HlomCO9soIFdVt5iBx3VfcTtTXCxS8bYerq5if5hZP1a3chLD9JGktFUcYfWOh9Q6g OOhGe5PH4t+oTL2+frP1WPi1NPe/354AFPJmTNLN4zTa0NOxL11Nd1kXJwZ8JgSBS74m vr3cRjYVNGDNnDF57b78SdXbakpdq0W4wcDqbSPpVD31bw6YbTdsWewAj8N9bHTDVX7v /mCwzYQpuA1EPhOTGpuEAo3ALTmNzt3MzMZj54w8ljiHnKQDjBa7qba5ko/ntZ6XtoP0 ahpdb0vPVBJX8iHGdMjLIOy/QTqg6FrihiF4i+zzbyA9BF27hloRZo6M47LhLA6LkLvb Lyng== X-Gm-Message-State: AOUpUlE8M3fWFaYsDvuUd5rXkOEORAFtm1QbJXDgB05GbyibRa2iC9bV N7F2ZG+7HZhVLEf76/+X4xSGqw== X-Google-Smtp-Source: AAOMgpcVYrqu/gVUbUCIJ+/vBCdMU0IUFyfMKgRT/5fpBGdT9eQJUoEqds9MNExra/KAhvrix57eSg== X-Received: by 2002:a17:902:b944:: with SMTP id h4-v6mr5163705pls.157.1531466608193; Fri, 13 Jul 2018 00:23:28 -0700 (PDT) Received: from [10.117.1.182] ([64.64.108.143]) by smtp.gmail.com with ESMTPSA id o4-v6sm7141157pgq.91.2018.07.13.00.23.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jul 2018 00:23:27 -0700 (PDT) To: Ard Biesheuvel Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo References: <20180704075117.7427-1-ming.huang@linaro.org> <20180704075117.7427-2-ming.huang@linaro.org> <1443c4db-6b50-c971-9e18-2b052a19515a@linaro.org> From: Ming Message-ID: Date: Fri, 13 Jul 2018 15:23:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 07:23:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 在 13/07/2018 14:46, Ard Biesheuvel 写道: > On 12 July 2018 at 10:50, Ming wrote: >> >> >> 在 11/07/2018 22:19, Ard Biesheuvel 写道: >>> On 4 July 2018 at 09:51, Ming Huang wrote: >>>> The edk2 commit bacfd6e let CpuDxe running latter. >>>> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >>>> gDS->SetMemorySpaceAttributes is invoked by some drivers. >>>> >>>> This issue can solve by adding Depex on gEfiCpuArchProtocolGuid >>>> to RealTimeClockLib. >>>> >>> >>> If this is the case, why do we still need the APRIORI DXE section? >>> >> >> This APRIORI DXE will be removed in V3. >> >> The new PciHostBridge which is developed by Heyi.Guo will add in V3. >> > > OK, so should I wait for the v3 series then? > > Heyi.Guo suggest that the new PciHostBridge patch set upstream in addition patch set for clarity. This patch set v3 will send soon. Thanks. >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ming Huang >>>> Signed-off-by: Heyi Guo >>>> --- >>>> Platform/Hisilicon/D03/D03.fdf | 4 ++++ >>>> Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf | 2 ++ >>>> 2 files changed, 6 insertions(+) >>>> >>>> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf >>>> index 1383aa1091..73e2b7e958 100644 >>>> --- a/Platform/Hisilicon/D03/D03.fdf >>>> +++ b/Platform/Hisilicon/D03/D03.fdf >>>> @@ -146,6 +146,10 @@ READ_STATUS = TRUE >>>> READ_LOCK_CAP = TRUE >>>> READ_LOCK_STATUS = TRUE >>>> >>>> + APRIORI DXE { >>>> + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>>> + } >>>> + >>>> INF MdeModulePkg/Core/Dxe/DxeMain.inf >>>> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>>> >>>> diff --git a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >>>> index 319c35c724..ae7116dc31 100644 >>>> --- a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >>>> +++ b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >>>> @@ -46,3 +46,5 @@ >>>> >>>> [Pcd] >>>> >>>> +[Depex] >>>> + gEfiCpuArchProtocolGuid >>>> -- >>>> 2.17.0 >>>>