From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: Michael Kubacki <mikuback@linux.microsoft.com>, <devel@edk2.groups.io>
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default
Date: Tue, 5 Apr 2022 08:52:53 -0600 [thread overview]
Message-ID: <dd93950b-ad39-0fcf-7710-a08f36a1fb89@quicinc.com> (raw)
In-Reply-To: <85400393-0b1e-6efa-b5c5-34b2bb2a4823@linux.microsoft.com>
Thanks. I hadn't come across that view before.
--
Rebecca Cran
On 4/5/22 08:46, Michael Kubacki wrote:
> It is printed in the error log. For your current PR:
> https://github.com/tianocore/edk2/pull/2744
>
> The results are printed in "Standard_Error_Output.log":
> https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=47584&view=ms.vss-test-web.build-test-results-tab&runId=346168&resultId=100012&paneView=attachments
>
>
> These are the results:
>
> """
> Files with formatting errors:
> Formatting errors in Library/ArmSmcLib/ArmSmc.c
> --- /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
> +++
> /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c.uncrustify_plugin
> @@ -25,10 +25,10 @@
> IN OUT UINTN *Arg1 OPTIONAL,
> IN OUT UINTN *Arg2 OPTIONAL,
> IN OUT UINTN *Arg3 OPTIONAL
> -)
> + )
> {
> ARM_SMC_ARGS Args;
> - UINTN ErrorCode;
> + UINTN ErrorCode;
>
> ZeroMem (&Args, sizeof (ARM_SMC_ARGS));
>
> @@ -80,7 +80,7 @@
> IN UINTN Function,
> IN OUT UINTN *Arg1 OPTIONAL,
> IN OUT UINTN *Arg2 OPTIONAL,
> - OUT UINTN *Arg3 OPTIONAL
> + OUT UINTN *Arg3 OPTIONAL
> )
> {
> return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
> @@ -102,7 +102,7 @@
> IN OUT UINTN *Arg1 OPTIONAL,
> OUT UINTN *Arg2 OPTIONAL,
> OUT UINTN *Arg3 OPTIONAL
> -)
> + )
> {
> return ArmCallSmc3 (Function, Arg1, Arg2, Arg3);
> }
> """
>
> These diffs can get very verbose and will overwhelm people if printed
> to standard console output. They are cleanly separated here.
>
> Thanks,
> Michael
>
> On 4/5/2022 10:31 AM, Rebecca Cran wrote:
>> So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix
>> anything, because we don't output TestSuites.xml to the console: if I
>> introduce a code style issue into a branch, CI still only prints the
>> following:
>>
>> PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test
>> NO-TARGET --
>> WARNING - A file header template is not specified in the config file.
>> WARNING - A function header template is not specified in the config
>> file.
>> ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c
>> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET
>> returned 1
>> ERROR - Overall Build Status: Error
>> PROGRESS - There were 1 failures out of 13 attempts
>>
>>
>> Could we get the diff printed *there* too?
>>
prev parent reply other threads:[~2022-04-05 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 16:19 [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default Michael Kubacki
2022-02-10 16:44 ` Michael D Kinney
2022-02-10 16:47 ` [edk2-devel] " Rebecca Cran
2022-02-23 17:48 ` Rebecca Cran
2022-02-25 21:18 ` Michael Kubacki
2022-04-05 14:31 ` Rebecca Cran
2022-04-05 14:46 ` Michael Kubacki
2022-04-05 14:52 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd93950b-ad39-0fcf-7710-a08f36a1fb89@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox