From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web11.7275.1649170374815605697 for ; Tue, 05 Apr 2022 07:52:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=LNg93WaZ; spf=pass (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649170374; x=1680706374; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=oiVqttjDXLPOtD7u9OD4IpbV2X7jOp1UUM7hDX6dikA=; b=LNg93WaZy/yS26k5vn03H4qTf2WrL7K9wV1q5yiC1b1uFnOCRguldAVo NyD66YJhnRNO0S8zcv/RoISSTvro2GmG9e+8+AvR7ErV58bR3wFknWQUw T9/XiMbaJFVqxoVfsWk0PeuP5CZ+oaiHbHFgtR8eFjmldJW4ozngoZmR0 0=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 05 Apr 2022 07:52:54 -0700 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2022 07:52:54 -0700 Received: from [10.110.39.192] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 5 Apr 2022 07:52:53 -0700 Message-ID: Date: Tue, 5 Apr 2022 08:52:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default To: Michael Kubacki , CC: Michael D Kinney , Liming Gao , Sean Brogan , Bret Barkelew References: <20220210161927.1847-1-mikuback@linux.microsoft.com> <7ab3cb92-85e1-c8ec-fc4e-20ae84a65c2f@quicinc.com> <788b70e7-3d38-dbd1-35a9-39eab17ac0fd@quicinc.com> <85400393-0b1e-6efa-b5c5-34b2bb2a4823@linux.microsoft.com> From: "Rebecca Cran" In-Reply-To: <85400393-0b1e-6efa-b5c5-34b2bb2a4823@linux.microsoft.com> Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Thanks. I hadn't come across that view before. -- Rebecca Cran On 4/5/22 08:46, Michael Kubacki wrote: > It is printed in the error log. For your current PR: > https://github.com/tianocore/edk2/pull/2744 > > The results are printed in "Standard_Error_Output.log": > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=47584&view=ms.vss-test-web.build-test-results-tab&runId=346168&resultId=100012&paneView=attachments > > > These are the results: > > """ > Files with formatting errors: >  Formatting errors in Library/ArmSmcLib/ArmSmc.c >  --- /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c >  +++ > /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c.uncrustify_plugin >  @@ -25,10 +25,10 @@ >  IN OUT UINTN  *Arg1 OPTIONAL, >  IN OUT UINTN  *Arg2 OPTIONAL, >  IN OUT UINTN  *Arg3 OPTIONAL >  -) >  +  ) >  { >  ARM_SMC_ARGS  Args; >  -  UINTN    ErrorCode; >  +  UINTN         ErrorCode; > >  ZeroMem (&Args, sizeof (ARM_SMC_ARGS)); > >  @@ -80,7 +80,7 @@ >  IN     UINTN  Function, >  IN OUT UINTN  *Arg1 OPTIONAL, >  IN OUT UINTN  *Arg2 OPTIONAL, >  -  OUT UINTN *Arg3 OPTIONAL >  +  OUT UINTN     *Arg3 OPTIONAL >  ) >  { >  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3); >  @@ -102,7 +102,7 @@ >  IN OUT UINTN  *Arg1 OPTIONAL, >  OUT UINTN     *Arg2 OPTIONAL, >  OUT UINTN     *Arg3 OPTIONAL >  -) >  +  ) >  { >  return ArmCallSmc3 (Function, Arg1, Arg2, Arg3); >  } > """ > > These diffs can get very verbose and will overwhelm people if printed > to standard console output. They are cleanly separated here. > > Thanks, > Michael > > On 4/5/2022 10:31 AM, Rebecca Cran wrote: >> So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix >> anything, because we don't output TestSuites.xml to the console: if I >> introduce a code style issue into a branch, CI still only prints the >> following: >> >> PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test >> NO-TARGET -- >> WARNING - A file header template is not specified in the config file. >> WARNING - A function header template is not specified in the config >> file. >> ERROR - /home/vsts/work/1/s/ArmPkg/Library/ArmSmcLib/ArmSmc.c >> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET >> returned 1 >> ERROR - Overall Build Status: Error >> PROGRESS - There were 1 failures out of 13 attempts >> >> >> Could we get the diff printed *there* too? >>