From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 7A10B7803EC for ; Tue, 19 Dec 2023 13:02:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=tfHIQ9CpDffWEfWGSiW1B3KnbVoypQZrmd79era3QgA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1702990959; v=1; b=TEokyOeEejFK5Xd0hPQBB98gU07kEriF/cs/oIh5RiRJFAXl+RSlJIYNvnzgDGSxZgbdMELD uz47K5+xD0yUfRPmOzFcHUL9nobMDtkd2V1jblqGU5BH4msWS9GqEXFbMyexlkpmhGsR4YQPIpR Ze/6SONxCURd3QCQdTHg23gI= X-Received: by 127.0.0.2 with SMTP id ztRaYY7687511xnZrR6wJmNX; Tue, 19 Dec 2023 05:02:39 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.11314.1702990957883157995 for ; Tue, 19 Dec 2023 05:02:38 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8CxuehnlIFl250CAA--.13133S3; Tue, 19 Dec 2023 21:02:31 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dxt+ZmlIFl5VoAAA--.2642S3; Tue, 19 Dec 2023 21:02:30 +0800 (CST) Message-ID: Date: Tue, 19 Dec 2023 21:02:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v4 18/37] MdePkg: Add a PCD feature flag named PcdPciIoTranslationIsEnabled From: "Chao Li" To: devel@edk2.groups.io, Michael D Kinney , Liming Gao Cc: Zhiguang Liu Reply-To: devel@edk2.groups.io,lichao@loongson.cn References: <20231212130932.2467028-1-lichao@loongson.cn> <17A017C0864F4177.31409@groups.io> In-Reply-To: <17A017C0864F4177.31409@groups.io> X-CM-TRANSID: AQAAf8Dxt+ZmlIFl5VoAAA--.2642S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAKCGWA-a4KPAABsC X-Coremail-Antispam: 1Uk129KBj93XoWxJrWkWr4rGrW8XFy3CrWDJrc_yoW8Gr4kpw srGayrta18Gr12yF17Wa47JryFqFWkCrZrKFZIywn3Wa9Yk3Z5Jw1kK3yrKFWSyryxta4j v3ySyFyj9a18Z3gCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyCb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVWxJr0_GcWle2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUAVWUtw Av7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x07UM5l8UUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3iZgpk696kliRss3TDXLZfZdx7686176AA= Content-Type: multipart/alternative; boundary="------------7IvQwsqh1JgoWqosoBG4PNRj" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TEokyOeE; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------7IvQwsqh1JgoWqosoBG4PNRj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Mike and Liming, Can you please review this patch? Thank you! Thanks, Chao On 2023/12/12 21:12, Chao Li wrote: > Some ARCH need to use MMIO to access PCI IO, such as ARM AARCH64 RISC-V > and LOONGARCH64. In some drivers, a PCD value is added to determine > whether to use MMIO. > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4584 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Chao Li > --- > MdePkg/MdePkg.dec | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index ac54338089..55f5230c31 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2018,6 +2018,12 @@ > # @Prompt Validate ORDERED_COLLECTION structure > gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedCollection|FALSE|BOOLEAN|0= x0000002a > =20 > + ## Indicates if PCI IO translation is used. > + # TRUE - PCI IO translation is enable. > + # FALSE - PCI IO translation is disable. > + # @Prompt Pci Io Translation Is Enabled. > + gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslationIsEnabled|FALSE|BOOLEAN|0x= 00000043 > + > [PcdsFixedAtBuild] > ## Status code value for indicating a watchdog timer has expired. > # EFI_COMPUTING_UNIT_HOST_PROCESSOR | EFI_CU_HP_EC_TIMER_EXPIRED -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112724): https://edk2.groups.io/g/devel/message/112724 Mute This Topic: https://groups.io/mt/103261681/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------7IvQwsqh1JgoWqosoBG4PNRj Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Mike and Liming,

Can you please review this patch? Thank you!


=
Thanks,
Chao
On 2023/12/12 21:12, Chao Li wrote:
Some ARCH need to use MMIO to =
access PCI IO, such as ARM AARCH64 RISC-V
and LOONGARCH64. In some drivers, a PCD value is added to determine
whether to use MMIO.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=
=3D4584

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
---
 MdePkg/MdePkg.dec | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac54338089..55f5230c31 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2018,6 +2018,12 @@
   # @Prompt Validate ORDERED_COLLECTION structure
   gEfiMdePkgTokenSpaceGuid.PcdValidateOrderedCollection|FALSE|BOOLEAN|0x00=
00002a
=20
+  ## Indicates if PCI IO translation is used.
+  #   TRUE  - PCI IO translation is enable.
+  #   FALSE - PCI IO translation is disable.
+  # @Prompt Pci Io Translation Is Enabled.
+  gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslationIsEnabled|FALSE|BOOLEAN|0x00=
000043
+
 [PcdsFixedAtBuild]
   ## Status code value for indicating a watchdog timer has expired.
   # EFI_COMPUTING_UNIT_HOST_PROCESSOR | EFI_CU_HP_EC_TIMER_EXPIRED
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#112724) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------7IvQwsqh1JgoWqosoBG4PNRj--