public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option
@ 2022-07-04  7:42 Sean Rhodes
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Rhodes @ 2022-07-04  7:42 UTC (permalink / raw)
  To: devel; +Cc: Sean Rhodes, Guo Dong, Ray Ni, Maurice Ma, Benjamin You

Hook up PCIE_BASE to PcdPciExpressBaseAddress

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..0de87bd6bd 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -33,6 +33,7 @@
   DEFINE UNIVERSAL_PAYLOAD            = FALSE
   DEFINE SECURITY_STUB_ENABLE         = TRUE
   DEFINE SMM_SUPPORT                  = FALSE
+  DEFINE PCIE_BASE                    = 0
   DEFINE PLATFORM_BOOT_TIMEOUT        = 3
   DEFINE ABOVE_4G_MEMORY              = TRUE
   DEFINE BOOT_MANAGER_ESCAPE          = FALSE
@@ -506,7 +507,7 @@
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100
-  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0
+  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE)
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option
@ 2022-07-04 20:46 Sean Rhodes
  2022-07-05  9:03 ` [edk2-devel] " Sheng Lean Tan
  0 siblings, 1 reply; 4+ messages in thread
From: Sean Rhodes @ 2022-07-04 20:46 UTC (permalink / raw)
  To: devel; +Cc: Sean Rhodes, Guo Dong, Ray Ni, Maurice Ma, Benjamin You

Hook up PCIE_BASE to PcdPciExpressBaseAddress

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index cfcf38578d..d8afb28d13 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -33,6 +33,8 @@
   DEFINE UNIVERSAL_PAYLOAD            = FALSE
   DEFINE SECURITY_STUB_ENABLE         = TRUE
   DEFINE SMM_SUPPORT                  = FALSE
+  DEFINE PCIE_BASE_ADDRESS            = 0
+  DEFINE PCIE_BASE_LENGTH             = 0
   DEFINE PLATFORM_BOOT_TIMEOUT        = 3
   DEFINE ABOVE_4G_MEMORY              = TRUE
   DEFINE BOOT_MANAGER_ESCAPE          = FALSE
@@ -506,8 +508,8 @@
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow|31
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutColumn|100
-  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0
-  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|0
+  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE_ADDRESS)
+  gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize|$(PCIE_BASE_LENGTH)
   gEfiMdeModulePkgTokenSpaceGuid.PcdGhcbBase|0
   gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed|FALSE
   gUefiCpuPkgTokenSpaceGuid.PcdSevEsIsEnabled|0
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option
  2022-07-04 20:46 [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option Sean Rhodes
@ 2022-07-05  9:03 ` Sheng Lean Tan
  2022-07-12  7:28   ` Sean Rhodes
  0 siblings, 1 reply; 4+ messages in thread
From: Sheng Lean Tan @ 2022-07-05  9:03 UTC (permalink / raw)
  To: Sean Rhodes, devel

[-- Attachment #1: Type: text/plain, Size: 56 bytes --]

Reviewed-by: Lean Sheng Tan< sheng.tan@9elements.com >

[-- Attachment #2: Type: text/html, Size: 444 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option
  2022-07-05  9:03 ` [edk2-devel] " Sheng Lean Tan
@ 2022-07-12  7:28   ` Sean Rhodes
  0 siblings, 0 replies; 4+ messages in thread
From: Sean Rhodes @ 2022-07-12  7:28 UTC (permalink / raw)
  To: Sheng Lean Tan, devel

[-- Attachment #1: Type: text/plain, Size: 109 bytes --]

This patch can be disregarded as the --pcd build option will be integrated into the coreboot build process.

[-- Attachment #2: Type: text/html, Size: 109 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-12  7:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-04 20:46 [PATCH] UefiPayloadPkg: Hook up PCIE_BASE build option Sean Rhodes
2022-07-05  9:03 ` [edk2-devel] " Sheng Lean Tan
2022-07-12  7:28   ` Sean Rhodes
  -- strict thread matches above, loose matches on Subject: below --
2022-07-04  7:42 Sean Rhodes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox