From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.26251.1629129848230671937 for ; Mon, 16 Aug 2021 09:04:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=E0rZz4oe; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629129847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c2OtvGPPTWn+tzyaBOFvFarqgtXZHQ7sw8VKMKvTniQ=; b=E0rZz4oedVVPXCnWZBhxOx5Iy8SBvq9scCgQbM5bdHxaLjm4vwII3Zw6NNaUBbjZPeVBl3 uK2/XWASbD7tnIu8zXfQUXJT73SgRjrHSFWRwjnNYFzb3q6OOedssxCSPXHXivYHGrRYQz vDsmXS3uhOFCJk/EA8jVkkGVkZ3Uawo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-305-nFI90zFANdWIH7fOhZhoTA-1; Mon, 16 Aug 2021 12:04:06 -0400 X-MC-Unique: nFI90zFANdWIH7fOhZhoTA-1 Received: by mail-wm1-f71.google.com with SMTP id w25-20020a1cf6190000b0290252505ddd56so4255781wmc.3 for ; Mon, 16 Aug 2021 09:04:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c2OtvGPPTWn+tzyaBOFvFarqgtXZHQ7sw8VKMKvTniQ=; b=grSAp1Aa6HysuSzEn1ylqj8kJpEunu1LCWmQDM3F4z9938WI9xl0dPMXSbkwkRsvsv jwod+aqyo0vOzm9T1cVTzBgl83yj0plYM8z9Sjax8mtE1/jF6yCc5XxmoiAa78BOeM7w fAdUiOW4aEdh766euCBHIEVhy3cut2NP4lA7TqjmldDIJ8MQ2f65UXD2GIrkzEo9EaTq uWABF0wNJBYmovsy258wFGeiX5oEqUFQu0hSPo0FTs9ZNn9ITX/ggghmrNPtMZDxGLVw ZlQ8THLmS2sGVGPbm37wrsCeL5Awi4HFussPA37W0v0VthMVI1AsDp6GGwdAkm7f4+4y VvxA== X-Gm-Message-State: AOAM531ByLO3VUx4mEV1xNIgz+69cPhYqzqop6AFbCElNIKD8AV28CHg VFx4H3q/Z0nJ31c+O7mgbrMFw/Fvr7lk8m82Y0ZfxuT+GGlMVjcBqWX0vIqcwt4QsXLnDadASXK VgPRGy0PaDpP9Ag== X-Received: by 2002:a05:600c:286:: with SMTP id 6mr14723525wmk.164.1629129845071; Mon, 16 Aug 2021 09:04:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPaLi/74+T9yvL57EKmce1ZXTljP3twT49BzGhPBtpN87zx4xy+Kr0kXQQ61bxZS2/x+YklQ== X-Received: by 2002:a05:600c:286:: with SMTP id 6mr14723506wmk.164.1629129844879; Mon, 16 Aug 2021 09:04:04 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id y15sm12068362wrw.58.2021.08.16.09.04.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 09:04:04 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2 2/4] OvmfPkg/VirtioMmioDeviceLib: Add virtio 1.0 support. To: devel@edk2.groups.io, jiewen.yao@intel.com, "kraxel@redhat.com" References: <20210816071109.101122-1-kraxel@redhat.com> <20210816071109.101122-3-kraxel@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Mon, 16 Aug 2021 18:04:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/16/21 3:35 PM, Yao, Jiewen wrote: > Hi Greg > Can we define MACRO to replace 1 or 2? That is very confusing. > > For example, > #define VIRT_IO_DEVICE_VERSION_0_95 1 > #define VIRT_IO_DEVICE_VERSION_1_00 2 Good idea. > > Thank you > Yao Jiewen