From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id AE16C941D21 for ; Thu, 23 May 2024 21:05:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZpiVYkUfymS6eWtrY3utmUKw+D1rqzulAlBeB8QYiyQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716498318; v=1; b=mhtILA+Y4xRh/5R4VgqrhM/KRAMrZlEN08njbKoxF3X4xwiHlN+KjJ7vnTYDn/dyXayLjFro EoNvrUFtB5ZiGUB7osyXqPFJwiu3TBL/OjUpujsNbJ2vbzIdFBz4FKQsCe9YYzRND10P2SX4BoZ SZSOKwYY596cqUKrhEIhrWFloT4KAcfzljpklkBWRvYVUQAhHTYowpi7Q+JIrjRlja97m8ghnVC B9hN3WZ/zDH4DQOnrnqHrkmvfle775wuRFXqUhUiwKqaXFvnPNT/ruj1s13eQIRchTwwbw5BPfF vkdR/i6qnnWF2e+G3R4nDE72jh1PuD4Bo/1b6nBX1jWNw== X-Received: by 127.0.0.2 with SMTP id gQOhYY7687511xuqncTgpWqo; Thu, 23 May 2024 14:05:18 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.1922.1716498316783139706 for ; Thu, 23 May 2024 14:05:16 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id 0A26E2067B22; Thu, 23 May 2024 14:05:16 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0A26E2067B22 Message-ID: Date: Thu, 23 May 2024 14:05:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 1/1] MdeModulePkg: Add the EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE attribute To: devel@edk2.groups.io, du.lin@intel.com, "mikuback@linux.microsoft.com" Cc: Liming Gao , "Kinney, Michael D" , "Ni, Ray" References: <20240518005757.1639-1-mikuback@linux.microsoft.com> From: "Oliver Smith-Denny" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 23 May 2024 14:05:16 -0700 Resent-From: osde@linux.microsoft.com Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eTjPVy245J2t1x5JL5Lq4EMYx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=mhtILA+Y; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/23/2024 2:17 AM, Du Lin wrote: > Thanks for the quick response. >=20 > Agree that the PI and UEFI specs are vague on SP. That is also why I opte= d to minimize code changes to DXE core for SP support in patch https://edk2= .groups.io/g/devel/message/118712. >=20 > Would it make more sense to let the caller determine if SP memory is avai= lable for UEFI via EFI resource types (e.g., EFI_RESOURCE_SYSTEM_MEMORY vs = EFI_RESOURCE_MEMORY_RESERVED)? >=20 > CDAT can be read in PEI phase via DOE method and CDAT is important to sup= port CXL 2.0. I believe CDAT spec is referencing EFI_MEMORY_TYPE and Memory= Attributes defined in UEFI spec section 7.2. "EfiConventionalMemory Type w= ith EFI_MEMORY_SP Attribute" may suggest that the memory type shall be EfiC= onventionalMemory and the attribute shall have SP set when reporting the me= mory to OS. And the concern is whether this combination can still be suppor= ted if we always mark resource HOBs with SP set as EfiGcdMemoryTypeReserved= . Thanks for the clarification. I agree that it makes sense to let the resource HOB creator determine whether UEFI will put this in system memory or reserved memory. DxeCore at that point could decide to not allocate any memory with the EFI_MEMORY_SP attribute (or it could decide it doesn't care). We are meeting with some CXL stakeholders to make sure there is no concern with changing this patch and then we will respin this. Thanks, Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119168): https://edk2.groups.io/g/devel/message/119168 Mute This Topic: https://groups.io/mt/106165072/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-