From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0A3EF941812 for ; Tue, 17 Oct 2023 14:39:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TVWwHHKFEERxARdO07rR1e2Hyw+dw/bLE2Wj1sMKU2Y=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697553549; v=1; b=DoKbNgw4ODOkLpL8UkZW5P6rROJIqDROqFgk3DfGbP7v2qtlVTsFrtHjz0WBl830jXWH//U/ BYjobYQFUBRdiGqiGc+x6S2w08r/vLf2bBm76xs6dxpD85/O78/ffw/mM/MV9Iil5ZczdvioJwU CYwWcmUpDaH1wuZUdg5DidgQ= X-Received: by 127.0.0.2 with SMTP id pSkRYY7687511xV40tzLeyRm; Tue, 17 Oct 2023 07:39:09 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.219006.1697553548852717645 for ; Tue, 17 Oct 2023 07:39:09 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-jRfFp1jUOfKBB85V_0cOUA-1; Tue, 17 Oct 2023 10:39:06 -0400 X-MC-Unique: jRfFp1jUOfKBB85V_0cOUA-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70E3438107B1; Tue, 17 Oct 2023 14:39:06 +0000 (UTC) X-Received: from [10.39.193.132] (unknown [10.39.193.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F139D492BFA; Tue, 17 Oct 2023 14:39:05 +0000 (UTC) Message-ID: Date: Tue, 17 Oct 2023 16:39:04 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v5 2/2] OvmfPkg/RiscVVirt: Override for RV CPU Features To: devel@edk2.groups.io, dhaval@rivosinc.com References: <20231017121755.190285-1-dhaval@rivosinc.com> <20231017121755.190285-3-dhaval@rivosinc.com> From: "Laszlo Ersek" In-Reply-To: <20231017121755.190285-3-dhaval@rivosinc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xZD8Z8tCJgOXGemWP3RvzrzYx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=DoKbNgw4; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/17/23 14:17, Dhaval Sharma wrote: > This PCD provides a way for platform to override any > HW features that are default enabled by previous stages > of FW (like OpenSBI). For the case where previous/prev > stage has disabled the feature, this override is not > useful and its usage should be avoided. >=20 > Ard Biesheuvel > Jiewen Yao > Jordan Justen > Gerd Hoffmann > Sunil V L > Andrei Warkentin (4) You forgot to prepend "Cc:". (5) The cover letter (0/2 email here) should contain all the Cc: tags from the patches' commit messages, so that whoever gets at least one patch CC'd from the series also get the cover letter for the series. Thanks Laszlo >=20 > Signed-off-by: Dhaval Sharma > --- > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc b/OvmfPkg/RiscVVirt/Risc= VVirt.dsc.inc > index fe320525153f..8b5e010316ba 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,8 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > =20 > [PcdsFixedAtBuild.common] > + gEfiMdePkgTokenSpaceGuid.PcdRVFeatureOverride|0 > + > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109689): https://edk2.groups.io/g/devel/message/109689 Mute This Topic: https://groups.io/mt/102016149/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-