From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.175931.1673894726611405278 for ; Mon, 16 Jan 2023 10:45:26 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@quicinc.com header.s=qcppdkim1 header.b=jcRXxqzW; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.180.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30GISjMe030081; Mon, 16 Jan 2023 18:45:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=KhhTBsBGSfpA1uPjD1WPgMlVehhAwdfliU8Pms1vjYs=; b=jcRXxqzWDPjG6xmfjUI+yzx8MbNBi3vFlv8bZhOEosI63BWHRBzKKVtZVN1Y960PbXm9 b9GERnnbRw9FIXweuYxAuk2ochCTVF85sn99uRfDhXYVCSc1XYGUKGhBJ/ZFBMUEkX5G WtMS8pnQ666gX37FN7CDckcD+GbTXtZIr2VxDRM9cxN1G3s8w9Dcx+MBpn0SqqD1ezqb mOTFVC2MzCi2T1iVoGOABhlSpojTvEXSdcNPUjAVmo3Y1zFpIIjqGAt7iywzQRqIkY31 TLR5fdNdjH5sbr3cTwuRsxvrMGHpp970MZng3tu7rqWrYhWfs66fJsbIn1ysTxfceEQV Lw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3n3mg3c2q5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jan 2023 18:45:16 +0000 Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 30GIjFlM016684 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Jan 2023 18:45:15 GMT Received: from [10.110.3.79] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 16 Jan 2023 10:45:14 -0800 Message-ID: Date: Mon, 16 Jan 2023 11:45:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v4 2/3] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls To: Kun Qin , , Sami Mujawar , Ard Biesheuvel , "Leif Lindholm" , Jian J Wang , Liming Gao , Tiger Liu References: <20230104153727.345236-1-rebecca@quicinc.com> <20230104153727.345236-3-rebecca@quicinc.com> <1737D7D0377487BE.3916@groups.io> <1497c8b2-18f4-45ca-f30d-b06a33cd83ea@gmail.com> From: "Rebecca Cran" In-Reply-To: <1497c8b2-18f4-45ca-f30d-b06a33cd83ea@gmail.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: H0rqH9JyGPQW5Whgkba_BhYCp4kRI6Km X-Proofpoint-GUID: H0rqH9JyGPQW5Whgkba_BhYCp4kRI6Km X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-16_15,2023-01-13_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 malwarescore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=961 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301160139 X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 30GISjMe030081 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 1/6/23 15:16, Kun Qin wrote: >>> +=C2=A0 // Blocking >>> +=C2=A0 while (TRUE) { >>> +=C2=A0=C2=A0=C2=A0 if (GetApState (CpuData) =3D=3D CpuStateFinished)= { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CpuData->State =3D CpuStateIdle; >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>> +=C2=A0=C2=A0=C2=A0 } >>> + >>> +=C2=A0=C2=A0=C2=A0 if ((TimeoutInMicroseconds !=3D 0) && (Timeout =3D= =3D 0)) { > [KQ-2] This will make the core never being able to accept the subsequen= t=20 > start up calls due to this CPU data state will > never be updated to CpuStateIdle. If this AP completes the job after=20 > timeout, ApProcedure will only be able to transition > its state to CpuStateFinished. Should we add a timer (when there is a=20 > timeout period specified) and use CpuData->CheckThisAPEvent > to check and try to sync the CPU states for this case? I think making a change to StartupThisAP and StartupAllAPs to reset any=20 cores in CpuStateFinished back to CpuStateIdle should work? --=20 Rebecca Cran