public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel@lists.01.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [Patch] Maintainers.txt: Add the rule to hand over the package maintain role
Date: Wed, 28 Nov 2018 13:08:08 +0100	[thread overview]
Message-ID: <de35c9a3-84be-b6de-dfa6-b6ef664143a8@redhat.com> (raw)
In-Reply-To: <1543390308-9036-1-git-send-email-liming.gao@intel.com>

On 11/28/18 08:31, Liming Gao wrote:
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  Maintainers.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 91a4657adc..d75bbe278d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -6,7 +6,9 @@ EDK II.
>  
>  In general, you should not privately email the maintainer. You should
>  email the edk2-devel list, and Cc the package maintainers and
> -reviewers.
> +reviewers. If the package maintainer wants to hand over his role to 
> +other people, the package maintainer should send the patch to update 
> +Maintainers.txt with new maintainer.
>  
>  Descriptions of section entries:
>  
> 

(1) Using "his" in the above context is grammatically correct English,
as far as I know (note: I'm not a native speaker).

However, given the TianoCore Code of Conduct at

  https://www.tianocore.org/coc.html

I'm going to ask you to please replace "his" with "the".

(2) Please append: "..., and the new maintainer should follow up with an
Acked-by or a Reviewed-by".

Thanks,
Laszlo


      parent reply	other threads:[~2018-11-28 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  7:31 [Patch] Maintainers.txt: Add the rule to hand over the package maintain role Liming Gao
2018-11-28 10:29 ` Ni, Ruiyu
2018-11-28 12:08 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de35c9a3-84be-b6de-dfa6-b6ef664143a8@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox