From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.3183.1572510061212056068 for ; Thu, 31 Oct 2019 01:21:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S8LFM3lh; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572510060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxWeR1HjMkGzXhFczumGFi/yIR/mOtMgWv3UBCgvxio=; b=S8LFM3lhBitnLZAJvb7FgHeoeBbUwIgBCVv3k5DhDsuQ5Ir8N4qIpvDLcrZ1QzxKMjYYU4 bHD6okGwEbosM9XjWk8MjzG6cgT1V0XR3pD7yBqzRtuEoJSH4GYNfk9yzJRiako3VdYLoZ Iz30OQEM+oFgS9BfIEfl2rbHX9o3c5Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-KNpRnk6-MYCa6Kw-6mlKCA-1; Thu, 31 Oct 2019 04:20:57 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C36491800D55; Thu, 31 Oct 2019 08:20:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-6.ams2.redhat.com [10.36.117.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5E9851001B36; Thu, 31 Oct 2019 08:20:54 +0000 (UTC) Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md To: Leif Lindholm Cc: devel@edk2.groups.io, abner.chang@hpe.com, Andrew Fish , Michael D Kinney , Gilbert Chen References: <1572227957-13169-1-git-send-email-abner.chang@hpe.com> <1572227957-13169-40-git-send-email-abner.chang@hpe.com> <20191029020120.GO16820@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: Date: Thu, 31 Oct 2019 09:20:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191029020120.GO16820@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: KNpRnk6-MYCa6Kw-6mlKCA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/29/19 03:01, Leif Lindholm wrote: > On Tue, Oct 29, 2019 at 02:07:20AM +0100, Laszlo Ersek wrote: >>> diff --git a/Readme.md b/Readme.md >>> index 27e4ce0..4b3d2a5 100644 >>> --- a/Readme.md >>> +++ b/Readme.md >>> @@ -148,6 +148,7 @@ as possible as we can. Currently EDK II contains tw= o submodules >>> =20 >>> - CryptoPkg/Library/OpensslLib/openssl >>> - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 >>> +- RiscVPkg/Library/RiscVOpensbiLib/opensbi >>> =20 >>> The latter one is actually required by previous one. It's inevitable >>> in openssl-1.1.1 (since stable201905) for floating point parameter >> >> This will take an update that's a bit more extensive -- please see "two >> submodules" just above the listing, and "latter one" right after the >> listing. Adding opensbi in the proposed spot breaks both statements. >=20 > This suggests the surrounding language should change. >=20 > Could we merge this to master?: >=20 > From 39f08033c934b3e631c40e373aa6a351323ab4aa Mon Sep 17 00:00:00 2001 > From: Leif Lindholm > Date: Tue, 29 Oct 2019 09:54:36 +0800 > Subject: [PATCH 1/1] Readme.md: remove positional references from submodu= le description >=20 > Remove references to the number of submodules in the tree, as well as > reword the referring to specific submodules as "former" and "previous". > This means we won't need to keep updating the surrounding text if we > add/remove submodules. >=20 > Signed-off-by: Leif Lindholm > --- > Readme.md | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/Readme.md b/Readme.md > index 27e4ce07719b..9bf60bede8ec 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -144,12 +144,12 @@ Signed-off-by: Contributor Name > # Submodules > =20 > Submodule in EDK II is allowed but submodule chain should be avoided > -as possible as we can. Currently EDK II contains two submodules > +as possible as we can. Currently EDK II contains the following submodule= s > =20 > - CryptoPkg/Library/OpensslLib/openssl > - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > =20 > -The latter one is actually required by previous one. It's inevitable > +ArmSoftFloatLib is actually required by OpensslLib. It's inevitable > in openssl-1.1.1 (since stable201905) for floating point parameter > conversion, but should be dropped once there's no such need in future > release of openssl. >=20 Good idea. When you post this in isolation for edk2, please add: Reviewed-by: Laszlo Ersek Thanks Laszlo