From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.4220.1622104267076056508 for ; Thu, 27 May 2021 01:31:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MXpCF2ao; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hyNMExoMSvODSDgDp5QK10DWWKmHETTu9iffb5fu5sc=; b=MXpCF2aojljtF/TB/+/ee9qFiPo/jTaoZbzrUrREoPINEQoPhpla/o6vtSo2Km7bJcFB/l BiQIRv8nJl1zCDM193T97fPnwMqIJQ/0i7qCK4sjLPcolhU0hKIgPgOs8RDpLp2PQFbNkg vsvmLqo093EzNECzh7ypPSMCaE6hEgI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-J_ObTH0COsyKmpZ29KCZQA-1; Thu, 27 May 2021 04:31:03 -0400 X-MC-Unique: J_ObTH0COsyKmpZ29KCZQA-1 Received: by mail-wm1-f70.google.com with SMTP id b67-20020a1ce4460000b029017517d833b9so1677802wmh.0 for ; Thu, 27 May 2021 01:31:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hyNMExoMSvODSDgDp5QK10DWWKmHETTu9iffb5fu5sc=; b=GHHYn/xxwldEZSAeR3pKePaotIE0DcDtVN3t9SyejzQNBe8RJ4IDwGFsU0kbKlHcr+ TLs+3hRPJER8NM2Iay1q3G1AkZ98jq38mLmF61Q7yIJ5acJozq6oKmbzf+C5YbouGd7F 5vqZJws3hPUz8/JikiENeDeTLnjOqHmp5cdNb1F5fYXrEadBKcdQMtwYKI+4J1Y72Bn6 V0tBR75GaiACU0ivf/+R7M9t4GFX2tMFAxdjKNNvDALBhEJIA7tJXMTyquwB7QoywXAh 4dJ4M1chCPR3/iUWVZzMClpXSJFIkfpN803u34wz/j0XdQS9RIKDay6NhxaSaN4KyTUo 1ZOg== X-Gm-Message-State: AOAM532lMJGQ9bqXm000x71REeWRo5IVT+DAqX53wHRGZW3ZSV5swSvz pauD+oxFGk2eTMzKET4m/9bZ0K67/cpXmg56MBGOHqF7NKaBr4STtC97PnORLGtrgBQRJfwc06Q L9Omp1RAPxg0FgQ== X-Received: by 2002:a1c:f019:: with SMTP id a25mr2308699wmb.64.1622104262390; Thu, 27 May 2021 01:31:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynv+PEJB2N4UJFvc/cWHbxD5Kq9VEWJw6KfarqUB/YrD4kDZPfQJtYsnhHKe3L8i++m2FBWQ== X-Received: by 2002:a1c:f019:: with SMTP id a25mr2308691wmb.64.1622104262256; Thu, 27 May 2021 01:31:02 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id y6sm9673787wmy.23.2021.05.27.01.31.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:31:01 -0700 (PDT) Subject: Re: [PATCH 28/43] OvmfPkg/PciHostBridgeLib: consolidate #includes and INF file sections To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-29-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:31:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-29-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > - In every C file, list every necessary public #include individually, with > an example identifier that's actually consumed. > > - Place all public #includes first, all module-private #includes second. > Separate them with a single empty line. Keep each section sorted in > itself. > > - Sort all sections in the INF file, except [Defines]. > > - Add unlisted lib classes. > > - Remove unnecessary #include directives, add unlisted #include > directives. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 7 +++--- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 22 +++++++----------- > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 24 +++++++++----------- > 3 files changed, 23 insertions(+), 30 deletions(-) Reviewed-by: Philippe Mathieu-Daude