From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DA1F9740051 for ; Thu, 29 Feb 2024 09:04:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KBcAPNiLZMEz4UXFpcCBN4bI37skqt263uVjSTsss50=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709197466; v=1; b=phleR9N2VqGN56Ag4EG5L5IuWoZ0y4SNYUgAEA1IyRG7jDVxlwFk9TnsOHFh8CqGlDe/3ugd Vjyh6bs4k24FTXcUun9m0uYFUmfX3htEjKt0XCqhoYyeWQoJMnmhdSKYPFSUm8e4t+gqSUONvNC bARvhQ7rAn4TdQbw5/GL/d9w= X-Received: by 127.0.0.2 with SMTP id 9o6AYY7687511xEtgJnX8Qc8; Thu, 29 Feb 2024 01:04:26 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.20357.1709197465667634440 for ; Thu, 29 Feb 2024 01:04:25 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-SWfhz8DQMH2X4lvrZWQMzQ-1; Thu, 29 Feb 2024 04:04:21 -0500 X-MC-Unique: SWfhz8DQMH2X4lvrZWQMzQ-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A409106D061; Thu, 29 Feb 2024 09:04:21 +0000 (UTC) X-Received: from [10.39.192.138] (unknown [10.39.192.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 570A71BDB1; Thu, 29 Feb 2024 09:04:20 +0000 (UTC) Message-ID: Date: Thu, 29 Feb 2024 10:04:19 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 00/13] use Redfish HTTP protocol To: devel@edk2.groups.io, nicklew@nvidia.com Cc: Abner Chang , Igor Kulchytskyy References: <20240229085248.111772-1-nicklew@nvidia.com> From: "Laszlo Ersek" In-Reply-To: <20240229085248.111772-1-nicklew@nvidia.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AAQ05YhNjLdrrdMRaBdWlSfEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=phleR9N2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Nickle, On 2/29/24 09:52, Nickle Wang via groups.io wrote: > Redfish HTTP protocol is introduced to edk2 RedfishPkg. Update=20 > RedfishClientPkg to use RedfishHttpLib. And remove the use of=20 > RedfishHttpCacheLib.=20 >=20 > I also replace several functions from RedfishLib with the function=20 > provided in RedfishHttpLib. In this way, there is no dependency on=20 > RedfishLib in RedfishClientPkg. >=20 > I noticed that there is false alarm in uncrustify check. When there > are deleted files, uncrustiry cannot check them and trigger uncrustify > failure. >=20 > Pull request is created here for testing CI:=20 > https://github.com/tianocore/edk2-redfish-client/pull/79 >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy >=20 > Nickle Wang (13): > RedfishClientPkg/.github: do not run uncrustify to deleted file. > RedfishClientPkg: remove RedfishHttpCacheLib > RedfishClientPkg: ues RedfishHttpLib > RedfishClientPkg/RedfishResourceConfigLib: ues RedfishHttpLib > RedfishClientPkg/RedfishFeatureUtilityLib: ues RedfishHttpLib > RedfishClientPkg/RedfishVersionLib: ues RedfishHttpLib > RedfishClientPkg/BiosDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionDxe: ues RedfishHttpLib > RedfishClientPkg/BootOptionCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemDxe: ues RedfishHttpLib > RedfishClientPkg/ComputerSystemCollectionDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryDxe: ues RedfishHttpLib > RedfishClientPkg/MemoryCollectionDxe: ues RedfishHttpLib can you please enable (shallow) threading in your git config? $ git config sendemail.thread true Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116154): https://edk2.groups.io/g/devel/message/116154 Mute This Topic: https://groups.io/mt/104640214/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-