From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F51B22729636 for ; Thu, 12 Apr 2018 10:45:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A20F8160F99; Thu, 12 Apr 2018 17:45:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com [10.10.120.142]) by smtp.corp.redhat.com (Postfix) with ESMTP id 83DDD2022DF5; Thu, 12 Apr 2018 17:45:20 +0000 (UTC) To: Leif Lindholm , Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Steve Capper , Supreeth Venkatesh References: <20180412005540.26651-1-lersek@redhat.com> <20180412172318.jtugn7p3w2qgr24y@bivouac.eciton.net> From: Laszlo Ersek Message-ID: Date: Thu, 12 Apr 2018 19:45:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180412172318.jtugn7p3w2qgr24y@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 12 Apr 2018 17:45:21 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 12 Apr 2018 17:45:21 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 17:45:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/12/18 19:23, Leif Lindholm wrote: > On Thu, Apr 12, 2018 at 12:09:46PM +0200, Ard Biesheuvel wrote: >> On 12 April 2018 at 02:55, Laszlo Ersek wrote: >>> Repo: https://github.com/lersek/edk2.git >>> Branch: depex_fixes >>> >>> ArmVirtQemu boots again, it just took a few more patches than I expected >>> :) >>> >>> Some of these patches will have to be ported to edk2-platforms, I think. >>> >>> Cc: Ard Biesheuvel >>> Cc: Leif Lindholm >>> Cc: Steve Capper >>> Cc: Supreeth Venkatesh >>> >>> Thanks, >>> Laszlo >>> >>> Laszlo Ersek (10): >>> Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify >>> ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf" >>> ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex >>> EmbeddedPkg: introduce NvVarStoreFormattedLib >>> ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly >>> ArmPlatformPkg/NorFlashDxe: cue the variable driver with >>> NvVarStoreFormatted >>> ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid >>> ArmPlatformPkg/PL031RealTimeClockLib: depend on >>> gEfiCpuArchProtocolGuid >>> ArmVirtPkg/PlatformHasAcpiDtDxe: depend on >>> gEfiVariableArchProtocolGuid >>> ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into >>> VariableRuntimeDxe >>> >> >> Laszlo, >> >> Thanks a lot for taking care of this. I am glad we finally got rid of >> the BEFORE depex in the NOR flash driver, which has been problematic >> for years. >> >> For the series, >> >> Reviewed-by: Ard Biesheuvel >> >> but please allow some time for Leif to chime in as well. > > Well, there are a couple of places where I could nitpick on > alphabetical sorting of includes, And, believe me, you would have my total agreement :), but in such cases, there's always a fork in the road: (a) add a separate patch that first sorts the includes and [LibraryClasses], without functional changes, or (b) just stick with the existing disorder, and get in and out as surgically as possible. My personal preference is (a), but it has drawn disagreement -- even accusations of pedantry :) :) --, and/or suggestions to squash such patches with functional changes, in the past, so I trod more lightly now. Rest assured, I didn't *miss* those places, I just elected to close my eyes! ;) > but none in files that weren't > already disorderly. And like Ard, I am very grateful for this quite > invasive (yet clean) bugfix. > > So, for 1-9/10: > Reviewed-by: Leif Lindholm Thank you! I shall get my TODO list (or, should I say, TODO "hash table", considering its cleanliness) in order, and then I'll get to pushing stuff. I *very* much appreciate the quick feedback on this! Cheers, Laszlo