* [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal @ 2017-04-21 21:25 Jeff Westfahl 2017-04-22 13:02 ` Zeng, Star 0 siblings, 1 reply; 3+ messages in thread From: Jeff Westfahl @ 2017-04-21 21:25 UTC (permalink / raw) To: edk2-devel; +Cc: Jeff Westfahl, Ruiyu Ni, Jaben Carsey The SMBIOS Type 0 BIOS segment field is currently displayed in decimal. Since this field is likely to have a value like 0xE800 or 0xF000, using hexadecimal seems like a better choice. Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 50d15ef..038f111 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -316,7 +316,7 @@ SmbiosPrintStructure ( case 0: PRINT_PENDING_STRING (Struct, Type0, Vendor); PRINT_PENDING_STRING (Struct, Type0, BiosVersion); - PRINT_STRUCT_VALUE (Struct, Type0, BiosSegment); + PRINT_STRUCT_VALUE_H (Struct, Type0, BiosSegment); PRINT_PENDING_STRING (Struct, Type0, BiosReleaseDate); ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal 2017-04-21 21:25 [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal Jeff Westfahl @ 2017-04-22 13:02 ` Zeng, Star 2017-04-25 0:53 ` Zeng, Star 0 siblings, 1 reply; 3+ messages in thread From: Zeng, Star @ 2017-04-22 13:02 UTC (permalink / raw) To: Jeff Westfahl, edk2-devel@lists.01.org Cc: Ni, Ruiyu, Carsey, Jaben, Zeng, Star It is ok to me. Reviewed-by: Star Zeng <star.zeng@intel.com> Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Westfahl Sent: Saturday, April 22, 2017 5:25 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com> Subject: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal The SMBIOS Type 0 BIOS segment field is currently displayed in decimal. Since this field is likely to have a value like 0xE800 or 0xF000, using hexadecimal seems like a better choice. Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 50d15ef..038f111 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -316,7 +316,7 @@ SmbiosPrintStructure ( case 0: PRINT_PENDING_STRING (Struct, Type0, Vendor); PRINT_PENDING_STRING (Struct, Type0, BiosVersion); - PRINT_STRUCT_VALUE (Struct, Type0, BiosSegment); + PRINT_STRUCT_VALUE_H (Struct, Type0, BiosSegment); PRINT_PENDING_STRING (Struct, Type0, BiosReleaseDate); ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal 2017-04-22 13:02 ` Zeng, Star @ 2017-04-25 0:53 ` Zeng, Star 0 siblings, 0 replies; 3+ messages in thread From: Zeng, Star @ 2017-04-25 0:53 UTC (permalink / raw) To: Jeff Westfahl, edk2-devel@lists.01.org Cc: Ni, Ruiyu, Carsey, Jaben, Zeng, Star The patch has been pushed at fed709deb444084594c2e11a1886819fa54afc00. Thanks, Star -----Original Message----- From: Zeng, Star Sent: Saturday, April 22, 2017 9:03 PM To: Jeff Westfahl <jeff.westfahl@ni.com>; edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>; Zeng, Star <star.zeng@intel.com> Subject: RE: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal It is ok to me. Reviewed-by: Star Zeng <star.zeng@intel.com> Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Westfahl Sent: Saturday, April 22, 2017 5:25 AM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com> Subject: [edk2] [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal The SMBIOS Type 0 BIOS segment field is currently displayed in decimal. Since this field is likely to have a value like 0xE800 or 0xF000, using hexadecimal seems like a better choice. Cc: Ruiyu Ni <ruiyu.ni@intel.com> Cc: Jaben Carsey <jaben.carsey@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Westfahl <jeff.westfahl@ni.com> --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c index 50d15ef..038f111 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c @@ -316,7 +316,7 @@ SmbiosPrintStructure ( case 0: PRINT_PENDING_STRING (Struct, Type0, Vendor); PRINT_PENDING_STRING (Struct, Type0, BiosVersion); - PRINT_STRUCT_VALUE (Struct, Type0, BiosSegment); + PRINT_STRUCT_VALUE_H (Struct, Type0, BiosSegment); PRINT_PENDING_STRING (Struct, Type0, BiosReleaseDate); ShellPrintHiiEx(-1,-1,NULL,STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * (Struct->Type0->BiosSize + 1)); -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-25 0:53 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-04-21 21:25 [PATCH] ShellPkg SmbiosView: Display Type 0 BIOS segment in hexadecimal Jeff Westfahl 2017-04-22 13:02 ` Zeng, Star 2017-04-25 0:53 ` Zeng, Star
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox