From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.1102.1597169414820954357 for ; Tue, 11 Aug 2020 11:10:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VUqrF79U; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: crobinso@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597169414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=b9yaoIyoDmognNRf30m3bEeg3CRunz475kdxoiFRS3Y=; b=VUqrF79U8hNyzVIYL6+9pM03/vOJikBGOffGfLNkLbZG1J0kMxpq/GVSH04Ig9ObZAh1uS o34kwo3PGyBiSonbKeRlvX8yTTEo0YxKW3Uu70zLyAbVuJxCtWMD4giJhFEe5z4LEA1Xqv lWaJv/VBtrT940g1k0JcJLEaNVbiH6Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-Q9VTMxUBP4Oqv5R8ZV2izA-1; Tue, 11 Aug 2020 14:10:09 -0400 X-MC-Unique: Q9VTMxUBP4Oqv5R8ZV2izA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6409980046F; Tue, 11 Aug 2020 18:10:08 +0000 (UTC) Received: from worklaptop.redhat.com (ovpn-118-49.rdu2.redhat.com [10.10.118.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F24A619B5; Tue, 11 Aug 2020 18:10:03 +0000 (UTC) From: "Cole" To: devel@edk2.groups.io Cc: michael.d.kinney@intel.com, lersek@redhat.com, Cole Robinson Subject: [PATCH] Add a stub CONTRIBUTING.md pointing to the wiki Date: Tue, 11 Aug 2020 14:09:53 -0400 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crobinso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Googling for 'edk2 pull request' did not find this wiki page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Add it to CONTRIBUTING.md for more discoverability Signed-off-by: Cole Robinson --- I tried submitting a PR to edk2: https://github.com/tianocore/edk2/pull/854 It was auto closed with: `All checks passed. Auto close personal build.` That confused me quite a bit. I could not understand what it was trying to say. I looked at other successfully merged PRs, noticed some hits about a 'push' label, but on looking to resubmit the PR it didn't seem like I had permission to set labels. Googling did not turn up any explanatory hits in the first two pages either. Eventually Laszlo pointed me in the right direction though A couple other suggestions to avoid that confusion * Extend the mergify message to clarify PRs are largely only meant for maintainers to use. Maybe point at the wiki page or CONTRIBUTING.md * Add a github new PR template with a comment giving more explanation: https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000000..212c69ce8b --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,3 @@ +# Contributing to EDK2 + +Contributor documentation is maintained on the wiki: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process -- 2.26.2