From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.12210.1597229954024330929 for ; Wed, 12 Aug 2020 03:59:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DIFvjqvi; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597229953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Uyio1owDd1Au8IIiKYwUW5r/tt5mqLI5Jc3kC/G3b6Y=; b=DIFvjqviBbgUlxa2Mxy9NkYOZelixwWp5cr6+4MUIB/vPeXqrnIUhvegxCiQ5VLqJjKXzy piez4UEZ0ZbFh2shqcHKegmVPu3VBQF5KtC/8T+vMvD83uDUnGfKQhfAhPAnfcKzwlTFcB FdTrLixhGu9fZ95E1mB57MeebzaOjYE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-S8G6BhUDOMGvKMVNb1etQQ-1; Wed, 12 Aug 2020 06:59:06 -0400 X-MC-Unique: S8G6BhUDOMGvKMVNb1etQQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9ECCD1835860; Wed, 12 Aug 2020 10:59:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-34.ams2.redhat.com [10.36.114.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB09D5D9D3; Wed, 12 Aug 2020 10:59:02 +0000 (UTC) Subject: Re: [PATCH v5 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto To: matthewfcarlson@gmail.com, devel@edk2.groups.io Cc: Jordan Justen , Ard Biesheuvel , Anthony Perard , Julien Grall References: <20200812022127.1205-1-matthewfcarlson@gmail.com> <20200812022127.1205-4-matthewfcarlson@gmail.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 12 Aug 2020 12:59:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200812022127.1205-4-matthewfcarlson@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/12/20 04:21, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > Updates the DSC's for Ovmf based platforms to add a RngLib that uses the > TimerLib. This is due to a later change that adds TimerLib as a dependency > for OpenSSL. The TimerLib based RngLib mimics the behavior of OpenSSL > previously and it is recommended to switch to a better source of > entropy than the system's performance counter. > > Ref: https://github.com/tianocore/edk2/pull/845 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Signed-off-by: Matthew Carlson > --- > OvmfPkg/Bhyve/BhyvePkgX64.dsc | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfXen.dsc | 1 + > 5 files changed, 6 insertions(+) > > diff --git a/OvmfPkg/Bhyve/BhyvePkgX64.dsc b/OvmfPkg/Bhyve/BhyvePkgX64.dsc > index 8eba48d109a3..4b1fbb361b28 100644 > --- a/OvmfPkg/Bhyve/BhyvePkgX64.dsc > +++ b/OvmfPkg/Bhyve/BhyvePkgX64.dsc > @@ -185,6 +185,7 @@ > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > PlatformSecureLib|OvmfPkg/Bhyve/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 9178ffeb71cb..fc1c8014eba1 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -189,6 +189,7 @@ > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index a665f78f0dc7..c76765723e2e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -194,6 +194,8 @@ > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > + > !if $(SECURE_BOOT_ENABLE) == TRUE > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf This hunk, unlike the other hunks, inserts an unwarranted-for empty line between the openssl lib resolution(s) and the new lib class resolution. This makes it more difficult to diff the DSC files against each other (which is something I do frequently). The discrepancy is also seen in the diffstat (2 lines for "OvmfPkgIa32X64.dsc", 1 line for every other DSC file). With the spurios newline removed; for this patch: Reviewed-by: Laszlo Ersek Thanks! Laszlo > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 17f345acf4ee..6992cfd98b70 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -193,6 +193,7 @@ > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 782803cb2787..416f81f06a04 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -179,6 +179,7 @@ > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > !endif > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >