From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68EE27803D9 for ; Wed, 5 Feb 2025 16:07:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=m6BIZ6MyigyKLWTGvczPRXTGEYIUDlAHcAAH6C8Q+uQ=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1738771631; v=1; x=1739030829; b=deYz7Req9jLoDQicANG9ufrD4iTtU8UTfzmyN6T1vxIjSF1KFX8H8NIZ5neMUASiOanLvddF Eds76OX/mg1uY72x5ZbX1b3H1HkN5eH76HITR0lHrpMrgb+cLh1poqsjAcz+MIG7QfT6qkz9eeX 1LlhW1CmYlJWKjHDuuwuzyu/3iOpCNVcgbr+6JLQbFIsD8LFLQedcqzxMPj/kG3FEdjrj4gKQxC mtoXLdJUYsUjLp1rm/QrxNDTGPKplyA2ciUJZN8StxjZhc5RI6DxUC/hl/GXQIboW38hpqWKAUB mBsZ57GAAwTWCYOAHVyHrSYRhghoCNcxzRDrjQqVk4VXw== X-Received: by 127.0.0.2 with SMTP id QcTjYY7687511xeasd8AFKt7; Wed, 05 Feb 2025 08:07:09 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.15901.1738771629113364723 for ; Wed, 05 Feb 2025 08:07:09 -0800 X-Received: from [10.137.194.171] (unknown [131.107.1.235]) by linux.microsoft.com (Postfix) with ESMTPSA id A8041203718D; Wed, 5 Feb 2025 08:07:08 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A8041203718D Message-ID: Date: Wed, 5 Feb 2025 08:07:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIER5bmFtaWMgU3RhY2sgQ29va2llcyBQUiBGb3IgZWRrMi1zdGFibGUyMDI1MDI=?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn, 'Michael Kinney' References: <002701db77ae$fc921ad0$f5b65070$@byosoft.com.cn> From: "Oliver Smith-Denny via groups.io" In-Reply-To: <002701db77ae$fc921ad0$f5b65070$@byosoft.com.cn> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 05 Feb 2025 08:07:09 -0800 Resent-From: osde@linux.microsoft.com Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hDI0CL9pvNendPDDiBkwkQJsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=deYz7Req; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks Liming. I also responded to the comment on the PR, but yes this is correct. Dynamic stack cookies are only used if CUSTOM_STACK_CHECK_LIB is defined in the platform. This change will affect platforms (as noted in the integration instructions) by requiring StackCheckLib to be linked against all custom entry point libs and modules with their own custom entry points (such as SEC modules). Thanks, Oliver On 2/5/2025 1:18 AM, gaoliming via groups.io wrote: > Oliver: > I have added 202502 milestone for this PR. >=20 > If the platform wants to enable this feature, it needs to define CUSTO= M_STACK_CHECK_LIB in its DSC file. If the platform doesn't enable this feat= ure, it will not be impacted by this change. Right? >=20 > Thanks > Liming >> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- >> =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Oliver >> Smith-Denny via groups.io >> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2025=E5=B9=B42=E6=9C=884=E6=97=A5 = 2:33 >> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Liming Gao ; >> Michael Kinney >> =E4=B8=BB=E9=A2=98: [edk2-devel] Dynamic Stack Cookies PR For edk2-stabl= e202502 >> >> Hi Liming, >> >> I am planning to merge https://github.com/tianocore/edk2/pull/6381 >> for stable tag edk2-stable202502. It has been under review for >> several months now and currently has multiple approvals, just >> waiting for Mike Kinney to confirm he is done reviewing and >> hopefully approve :). >> >> I will also put up a PR in edk2-platforms to resolve the >> breaking change there. >> >> Thanks, >> Oliver >> >> >> >> >=20 >=20 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121083): https://edk2.groups.io/g/devel/message/121083 Mute This Topic: https://groups.io/mt/111009400/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-