public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller
Date: Tue, 7 Aug 2018 14:23:42 +0200	[thread overview]
Message-ID: <df953b8b-da11-7a8f-09d5-1b98f968c7ec@redhat.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2CF038@SHSMSX152.ccr.corp.intel.com>

On 08/07/18 07:27, Gao, Liming wrote:
> Laszlo:
>   I mean to keep the minimal change in PCCT. I don't prevent the necessary change in PCCT code. Per your comments, this change in PCCT is necessary. If so, I am OK to this patch. 
> 
>   Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks -- I understand it better now. I will return to the RHBZ and
discuss the PCCTS question with the requestors. I will explain your
preference. If they feel it's really necessary to build PCCTS (antlr and
dlg) with the additional flags, even just for generating the lexer and
the parser for VfrCompile, I'll go ahead with your R-b for all six
patches. If they agree the PCCTS build can ignore the flags, I won't
modify PCCTS.

Thank you for taking the time to discuss this! I'll report back.
Laszlo


  reply	other threads:[~2018-08-07 12:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26  0:44 [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller Laszlo Ersek
2018-07-26  0:44 ` [PATCH 1/6] BaseTools/footer.makefile: expand BUILD_CFLAGS last for C files too Laszlo Ersek
2018-07-26  0:44 ` [PATCH 2/6] BaseTools/header.makefile: remove "-c" from BUILD_CFLAGS Laszlo Ersek
2018-07-26  0:44 ` [PATCH 3/6] BaseTools/Source/C: split "-O2" to BUILD_OPTFLAGS Laszlo Ersek
2018-07-26  0:44 ` [PATCH 4/6] BaseTools/Pccts: clean up antlr and dlg makefiles Laszlo Ersek
2018-07-26  0:44 ` [PATCH 5/6] BaseTools/Source/C: take EXTRA_OPTFLAGS from the caller Laszlo Ersek
2018-07-26  0:44 ` [PATCH 6/6] BaseTools/Source/C: take EXTRA_LDFLAGS " Laszlo Ersek
2018-08-02 15:40 ` [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and " Gao, Liming
2018-08-02 17:40   ` Laszlo Ersek
2018-08-06 14:48     ` Gao, Liming
2018-08-06 15:18       ` Laszlo Ersek
2018-08-06 16:41         ` Laszlo Ersek
2018-08-07  5:27           ` Gao, Liming
2018-08-07 12:23             ` Laszlo Ersek [this message]
2018-08-08 21:15               ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=df953b8b-da11-7a8f-09d5-1b98f968c7ec@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox