From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 544FB21BADAB9 for ; Tue, 7 Aug 2018 05:23:44 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A795E40241C4; Tue, 7 Aug 2018 12:23:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-247.rdu2.redhat.com [10.10.120.247]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A6D31C5B7; Tue, 7 Aug 2018 12:23:42 +0000 (UTC) To: "Gao, Liming" Cc: edk2-devel-01 References: <20180726004415.13381-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C4BDF@SHSMSX104.ccr.corp.intel.com> <7fcaa55c-abf5-25ff-2a08-6168ee10fd01@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2C6726@SHSMSX104.ccr.corp.intel.com> <44ddfa8b-7af5-47a7-d584-6777213706e3@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E2CF038@SHSMSX152.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Tue, 7 Aug 2018 14:23:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E2CF038@SHSMSX152.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 07 Aug 2018 12:23:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 07 Aug 2018 12:23:43 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/6] BaseTools/Source/C: take EXTRA_OPTFLAGS and EXTRA_LDFLAGS from the caller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Aug 2018 12:23:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/07/18 07:27, Gao, Liming wrote: > Laszlo: > I mean to keep the minimal change in PCCT. I don't prevent the necessary change in PCCT code. Per your comments, this change in PCCT is necessary. If so, I am OK to this patch. > > Reviewed-by: Liming Gao Thanks -- I understand it better now. I will return to the RHBZ and discuss the PCCTS question with the requestors. I will explain your preference. If they feel it's really necessary to build PCCTS (antlr and dlg) with the additional flags, even just for generating the lexer and the parser for VfrCompile, I'll go ahead with your R-b for all six patches. If they agree the PCCTS build can ignore the flags, I won't modify PCCTS. Thank you for taking the time to discuss this! I'll report back. Laszlo