From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.6018.1683680712938086055 for ; Tue, 09 May 2023 18:05:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=usjOHySU; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 475AE5C02C1; Tue, 9 May 2023 21:05:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 09 May 2023 21:05:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683680712; x=1683767112; bh=m5/OTYHeGFqtY3aAA4uBNfOSsveAGS5+zPC ypeWv3i8=; b=usjOHySUvO6D7THM2deGzfSiQOSNdhm004qPr8fN3+APtbD/mHj Vz4L7wPePCxhQkjiuQZKniNnkMOpK0/fkzLedDbt2SDRrRZBXW7c2MnoDaKRT+X/ M5cYxmzqdhoz1pFi7F/YQo+DZ/weijjrD/UA+7DwZnaL7dCJZ5YJA0sJb2BAA4HV 3A1wPH6LB6nZvYPbZDpTKARnEFRfDEdtair4bigacHy9K6nbcMWg8OX5q1Mm6mad VX4DrcUZt1NeTpzaKF3BqFhKut8JrQBvpctsK/3ZodjNEeJxs49IrIiV8bUwHsrp Evsx+kPmSFYZXvE5iLVFVvaRx6ts9SFFE2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1683680712; x= 1683767112; bh=m5/OTYHeGFqtY3aAA4uBNfOSsveAGS5+zPCypeWv3i8=; b=B UFjM7Omzhnw0Wva+/objrMZsJ4MManAnxIiW8lUa6s0fARdwmnh18gIhxpvUF6g8 D8LXRys3/+pb1I76Lpxgqr/r7tXg2Lyt5aV9PdrbfX2v536Jo7esxeD2btNYNvhb ENmxC46nzYo1iLgjIrRhN14e7uX3O97scCqgoO1/YSrj46GGKO22a652Z88Ohvym Qga5bAsCsMpHI8Ncdtw460eRBvyKnBr+Dyitv2wYN+WQJB4P5U7t1qwdu+TDnYLk 2sI0WIsLYt4ynzETR7b6Vf7s8LAetucLMLT6DfF0OnrhEBLMJvvf0spjpLLhYxOO TDW9fUQjj28NmxGrsT3xg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegvddggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhepteehjeevhfejueethfdtieevudegvdejkeefieetieevleeifeegvdeghfel gefgnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 May 2023 21:05:11 -0400 (EDT) Message-ID: Date: Tue, 9 May 2023 19:05:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build flags; add CLANGDWARF flags To: "Yao, Jiewen" , "devel@edk2.groups.io" , "Wang, Jian J" , "Lu, Xiaoyu1" , "Jiang, Guomin" , "Gao, Liming" , Michael D Kinney References: <20230505134310.1320041-1-rebecca@bsdio.com> <99d59203-98c4-0310-cad0-8d9c919df203@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Mike/Liming: The PR for this change is https://github.com/tianocore/edk2/pull/4343 . Please merge for edk2-stable202305. -- Rebecca Cran On 5/9/23 18:48, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Tuesday, May 9, 2023 12:46 PM >> To: devel@edk2.groups.io; Yao, Jiewen ; Wang, >> Jian J ; Lu, Xiaoyu1 ; Jiang, >> Guomin ; Gao, Liming >> >> Subject: Re: [PATCH 1/1] CryptoPkg: Delete CLANG35 and CLANG38 build >> flags; add CLANGDWARF flags >> >> Could someone from CryptoPkg add a "Reviewed-by" tag please? >> >> I'd like this to go into the upcoming edk2-stable202305 release. >> >> >> -- >> Rebecca Cran >> >> >> On 5/5/23 07:43, Rebecca Cran wrote: >>> Since CLANG35 and CLANG38 toolchains have been deleted from >>> tools_def.template, delete the build flags for them from CryptoPkg. >>> >>> Since CLANGDWARF has replaced CLANG38, add build flags for it to the >>> CryptoPkg .inf files. >>> >>> Signed-off-by: Rebecca Cran >>> --- >>> CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +-- >>> CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 3 +-- >>> CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 3 +-- >>> CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf | 3 +-- >>> CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 3 +-- >>> CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf | 3 +-- >>> CryptoPkg/Library/OpensslLib/OpensslLib.inf | 3 +-- >>> CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 3 +-- >>> CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 3 +-- >>> CryptoPkg/Library/OpensslLib/OpensslLibFull.inf | 3 +-- >>> CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf | 3 +-- >>> 11 files changed, 11 insertions(+), 22 deletions(-) >>> >>> diff --git a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >>> index 5be1724f0852..07b984869629 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf >>> @@ -110,8 +110,7 @@ [BuildOptions] >>> # >>> # suppress the following warnings so we do not break the build with >> warnings-as-errors: >>> # >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> XCODE:*_*_*_CC_FLAGS = -std=c99 >>> diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf >>> index 66261138a00b..d10c83b53c09 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf >>> @@ -97,8 +97,7 @@ [BuildOptions] >>> # >>> # suppress the following warnings so we do not break the build with >> warnings-as-errors: >>> # >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> XCODE:*_*_*_CC_FLAGS = -std=c99 >>> diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> index 07dbc0e7a8bd..56b4f7306d30 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> @@ -106,8 +106,7 @@ [BuildOptions] >>> # >>> # suppress the following warnings so we do not break the build with >> warnings-as-errors: >>> # >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> XCODE:*_*_*_CC_FLAGS = -std=c99 >>> diff --git a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf >>> index 4ad59b7bbc59..e7801b24c9a0 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/SecCryptLib.inf >>> @@ -81,8 +81,7 @@ [BuildOptions] >>> # >>> # suppress the following warnings so we do not break the build with >> warnings-as-errors: >>> # >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> XCODE:*_*_*_CC_FLAGS = -std=c99 >>> diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf >>> index ab1993087167..109e08377a2d 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf >>> @@ -105,6 +105,5 @@ [BuildOptions] >>> >>> XCODE:*_*_*_CC_FLAGS = -mmmx -msse -std=c99 >>> >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> diff --git a/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf >> b/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf >>> index 80261794470f..c3d1d61e59c5 100644 >>> --- a/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf >>> +++ b/CryptoPkg/Library/BaseCryptLib/UnitTestHostBaseCryptLib.inf >>> @@ -78,8 +78,7 @@ [BuildOptions] >>> # >>> # suppress the following warnings so we do not break the build with >> warnings-as-errors: >>> # >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno- >> error=incompatible-pointer-types >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=incompatible- >> pointer-types >>> XCODE:*_*_*_CC_FLAGS = -std=c99 >>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >>> index 86a00b1c4b2a..0f64c9fa7eca 100644 >>> --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >>> @@ -639,8 +639,7 @@ [BuildOptions] >>> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno- >> error=format >>> GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno- >> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized - >> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> # Revisit after switching to 3.0 branch >>> GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable >>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf >>> index 2e4f95909b51..ebada80d9dd3 100644 >>> --- a/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf >>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf >>> @@ -687,8 +687,7 @@ [BuildOptions] >>> # >>> GCC:*_*_IA32_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) >> $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno- >> error=unused-but-set-variable >>> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) >> $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno- >> error=format -Wno-format -Wno-error=unused-but-set-variable - >> DNO_MSABI_VA_FUNCS >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized - >> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> # Revisit after switching to 3.0 branch >>> GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable >>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >>> index 637d4769e8ca..311cd1e6051a 100644 >>> --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf >>> @@ -589,8 +589,7 @@ [BuildOptions] >>> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno- >> error=format >>> GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno- >> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized - >> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> # Revisit after switching to 3.0 branch >>> GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable >>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf >>> index c5f90221fc66..52bb4aeaa5f1 100644 >>> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf >>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf >>> @@ -694,8 +694,7 @@ [BuildOptions] >>> GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable -Wno- >> error=format >>> GCC:*_*_RISCV64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=maybe- >> uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> GCC:*_*_LOONGARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno- >> error=maybe-uninitialized -Wno-format -Wno-error=unused-but-set-variable >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized - >> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> # Revisit after switching to 3.0 branch >>> GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable >>> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf >>> index 076295244a2a..2ea117e506f2 100644 >>> --- a/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf >>> +++ b/CryptoPkg/Library/OpensslLib/OpensslLibFullAccel.inf >>> @@ -742,8 +742,7 @@ [BuildOptions] >>> # >>> GCC:*_*_IA32_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) >> $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno- >> error=unused-but-set-variable >>> GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) >> $(OPENSSL_FLAGS_CONFIG) -Wno-error=maybe-uninitialized -Wno- >> error=format -Wno-format -Wno-error=unused-but-set-variable - >> DNO_MSABI_VA_FUNCS >>> - GCC:*_CLANG35_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> - GCC:*_CLANG38_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >>> + GCC:*_CLANGDWARF_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized >> -Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> GCC:*_CLANGPDB_*_CC_FLAGS = -std=c99 -Wno-error=uninitialized - >> Wno-error=incompatible-pointer-types -Wno-error=pointer-sign -Wno- >> error=implicit-function-declaration -Wno-error=ignored-pragma-optimize >>> # Revisit after switching to 3.0 branch >>> GCC:*_GCC5_*_CC_FLAGS = -Wno-unused-but-set-variable