From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EF10C211D07AC for ; Fri, 1 Mar 2019 07:30:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7CCCD10DA84; Fri, 1 Mar 2019 15:30:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-56.rdu2.redhat.com [10.10.120.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id AFB1D5C1B5; Fri, 1 Mar 2019 15:30:30 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org References: <20190301053957.3572-1-eric.dong@intel.com> From: Laszlo Ersek Message-ID: Date: Fri, 1 Mar 2019 16:30:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190301053957.3572-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 01 Mar 2019 15:30:31 +0000 (UTC) Subject: Re: [Patch v2 0/4] Simplify CPU Features solution. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Mar 2019 15:30:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Eric, On 03/01/19 06:39, Eric Dong wrote: > V2 Changes include: > 1. Add ASSERT to make sure PcdCpuFeaturesSetting and > PcdCpuFeaturesCapability have equal size. > 2. Correct comment block on IsCpuFeatureSetInCpuPcd() references > "PcdCpuFeaturesSupport". It should reference "CpuBitMask". > > V1 Changes includes: > 1. Optimize PCD PcdCpuFeaturesUserConfiguration > 2. Limit useage of PcdCpuFeaturesSupport > 3. Remove some useless APIs. > Detail explanation please check each patch's introduction. > > Cc: Ray Ni > Cc: Laszlo Ersek > Eric Dong (4): > UefiCpuPkg/RegisterCpuFeaturesLib: Remove useless functions. > UefiCpuPkg/RegisterCpuFeaturesLib: Optimize PCD > PcdCpuFeaturesUserConfiguration. > UefiCpuPkg/RegisterCpuFeaturesLib: Simplify PcdCpuFeaturesSupport. > UefiCpuPkg/RegisterCpuFeaturesLib: Correct comments. > > .../Include/Library/RegisterCpuFeaturesLib.h | 34 ------ > .../RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 114 ++++++--------------- > .../DxeRegisterCpuFeaturesLib.inf | 3 +- > .../PeiRegisterCpuFeaturesLib.inf | 3 +- > .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 - > .../RegisterCpuFeaturesLib.c | 64 ++---------- > UefiCpuPkg/UefiCpuPkg.dec | 9 +- > 7 files changed, 45 insertions(+), 184 deletions(-) > sorry, I'm overloaded. Given that the platforms that I co-maintain don't use RegisterCpuFeaturesLib, I'd like to skip the v2 review. Please remember to push this series *after* the edk2-stable201903 tag is made. Because this is not a bugfix. Thanks Laszlo