From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
<devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Graeme Gregory <graeme@xora.org.uk>
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes
Date: Tue, 19 Sep 2023 15:17:16 +0100 [thread overview]
Message-ID: <dfe17acd-65ad-4829-a696-f1829357118d@quicinc.com> (raw)
In-Reply-To: <2a5c9133-cbf0-4b7d-89e0-e6cebd4d5158@linaro.org>
On 2023-09-19 13:03, Marcin Juszkiewicz wrote:
> W dniu 18.09.2023 o 13:35, Leif Lindholm pisze:
>> On Mon, Sep 18, 2023 at 13:03:12 +0200, Marcin Juszkiewicz wrote:
>>> There are some changes in progress which make BL1 bigger than 0x8000
>>> which EDK2 uses.
>>>
>>> TF-A defines BL1 size to be 0x12000 one. So let follow it.
>>>
>>> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>>
>> This fixes a TF-A bug that you uncovered this morning, and I think
>> that's worth pointing out in the commit message.
>>
>> However,
>> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>>
>> *But* this is a breaking change SoI want to hold off on merging
>> this until the TF-A bugfix has been merged, so we can update the
>> edk2-non-osi binaries at the same time, and minimise the amount of
>> pain.
>>
>> Note for the interested:
>> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/23417
>> TL;DR: the fip base and bl1 size don't line up. The bl1 size was
>> already set to sufficient size, but after RME support in TF-A, bl1
>> size grows beyond start of fip.
>
> TF-A part is now merged.
Excellent!
Could you roll up a new set of binaries for edk2-non-osi?
Then I can merge them at the same time and leave only a minor gap of
brokenness.
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108838): https://edk2.groups.io/g/devel/message/108838
Mute This Topic: https://groups.io/mt/101430708/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-19 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 11:03 [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: enlarge BL1/FIP sizes Marcin Juszkiewicz
2023-09-18 11:35 ` Leif Lindholm
2023-09-18 12:33 ` Ard Biesheuvel
2023-09-18 13:06 ` Marcin Juszkiewicz
2023-09-19 13:13 ` Ard Biesheuvel
2023-09-20 19:24 ` Leif Lindholm
2023-09-19 12:03 ` Marcin Juszkiewicz
2023-09-19 14:17 ` Leif Lindholm [this message]
2023-09-20 19:22 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfe17acd-65ad-4829-a696-f1829357118d@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox