[edk2-devel] IpmiLib is a NULL instance

["memristor2 via groups.io" <memristor2=proton.me@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]

Hello,
I was building the IpmifeaturePkg from the OutOfBandManagementPkg in edk2-platforms and saw the the components were not working in Run-time. I checkout out the instances in the edk2-platforms/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc and realized that this instance was used for all modules using IpmiLib:

IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf

which meant all the the drivers using the IpmiSubmitCommand routine would simply calling a NULL routine.
shouldn't it be like this?:

[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
...
IpmiLib|MdeModulePkg/Library/PeiIpmiLibIpmiPpi/PeiIpmiLibIpmiPpi.inf

[LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER]
... IpmiLib|MdeModulePkg/Library/DxeIpmiLibIpmiProtocol/DxeIpmiLibIpmiProtocol.inf

[LibraryClasses.common.DXE_SMM_DRIVER]

...
IpmiLib|MdeModulePkg/Library/SmmIpmiLibSmmIpmiProtocol/SmmIpmiLibSmmIpmiProtocol.inf

Sent with [Proton Mail](https://proton.me/) secure email.

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120401): https://edk2.groups.io/g/devel/message/120401
Mute This Topic: https://groups.io/mt/108071920/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3962 bytes --]