From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id AFEFCD80A07 for ; Tue, 16 Apr 2024 10:16:02 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=IDcPZaL9EhurS1rdgHv4z3y/Ovc7SL4qoSv11acjB2c=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1713262561; v=1; b=dIpc3t+XibfJkyai0534M4Ssksc39wBmm1BMuT982RR1FHNp0s9tJQcTFrky2EyiaFPyaWBC KHTKh1zthaaxQX8lHBPGEosbKnSk4MzXrR9KTONpO4VkEMK6HE8TM3TGh4EXM+G6lE1xMM0fz4e PBr3iQbxAlw6Hy+Xvcvj2KIsvbU7jAs5HCFh9bw6XwIBKBB2ROwxiQmbLeSmpj3CmEdr26bKDfc IwAvc5n1pW9qQcI9SB2PopB0WZqk8rnMMwniy1/vluY7N5pXS8xLBp/kzCcOunhtfHQVHmG61Pe owjTRsRtXcDKBbaspJz2ERwvlYweD627y7SeAIEQASKDQ== X-Received: by 127.0.0.2 with SMTP id iXNhYY7687511xK32sjqzmHJ; Tue, 16 Apr 2024 03:16:01 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.16620.1713262560435170974 for ; Tue, 16 Apr 2024 03:16:00 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-bWFFfu3xNUeb_TcdNiC7vg-1; Tue, 16 Apr 2024 06:15:55 -0400 X-MC-Unique: bWFFfu3xNUeb_TcdNiC7vg-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC0DF806528; Tue, 16 Apr 2024 10:15:54 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 990931121313; Tue, 16 Apr 2024 10:15:54 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 4A5C218009E6; Tue, 16 Apr 2024 12:15:49 +0200 (CEST) Date: Tue, 16 Apr 2024 12:15:49 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, min.m.xu@intel.com Cc: Ard Biesheuvel , Jiewen Yao Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Message-ID: References: <20240415075555.499-1-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <20240415075555.499-1-min.m.xu@intel.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 16 Apr 2024 03:16:00 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fGikrLUnVXdQB2wndXBx0Vf9x7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dIpc3t+X; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Mon, Apr 15, 2024 at 03:55:49PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4752 > > HashLibTdx and TdTcg2Dxe are designed for Intel TDX enlightened OVMF. > They're more reasonable to be put in OvmfPkg than in SecurityPkg. > > SecTpmMeasurementLibTdx is not used anymore. So it is deleted in this > patch-set. > > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.c (100%) > rename {SecurityPkg => OvmfPkg}/Library/HashLibTdx/HashLibTdx.inf (100%) > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/MeasureBootPeCoff.c (100%) > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.c (100%) > rename {SecurityPkg => OvmfPkg}/Tcg/TdTcg2Dxe/TdTcg2Dxe.inf (100%) Better place them in OvmfPkg/IntelTdx ? Otherwise looks fine to me. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117875): https://edk2.groups.io/g/devel/message/117875 Mute This Topic: https://groups.io/mt/105531957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-