From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8A8A1AC1203 for ; Mon, 29 Jan 2024 12:59:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jCqzzFi0wtgVCJybtDi1DPlOR1TmErKAPCtlFMoCOyM=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1706533183; v=1; b=pPSiCqb7NUNs6L6R0Zq/35btCF6hOAtfu4p54on0f1JwXFi30Q5udMOWNzpKMO4tyyT7wXBI ElByAmx4vyCWzJBXtsfsQ/AnLmjuL+W74b9tWLqnOrDR3bSZIVXh8JRiI2IyxfaKS/tYk3y9u1Q ZC1xqoytYOHtMEGaUMeDtjxU= X-Received: by 127.0.0.2 with SMTP id 7WKcYY7687511xQ1JyJqhOB5; Mon, 29 Jan 2024 04:59:43 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.13850.1706533182656968447 for ; Mon, 29 Jan 2024 04:59:42 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-x_daE27yMNOZoODohnSQIQ-1; Mon, 29 Jan 2024 07:59:36 -0500 X-MC-Unique: x_daE27yMNOZoODohnSQIQ-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E1356185A780; Mon, 29 Jan 2024 12:59:35 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.180]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F7501121306; Mon, 29 Jan 2024 12:59:35 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id E6C46180038B; Mon, 29 Jan 2024 13:59:33 +0100 (CET) Date: Mon, 29 Jan 2024 13:59:33 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH 01/16] OvmfPkg/BaseMemEncryptSevLib: Re-organize page state change support Message-ID: References: <7289d8c5217907e711038e92cdec0c38ffe2f727.1706307195.git.thomas.lendacky@amd.com> MIME-Version: 1.0 In-Reply-To: <7289d8c5217907e711038e92cdec0c38ffe2f727.1706307195.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kQHdaJPJEMPXB68eJBoja4ROx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pPSiCqb7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Jan 26, 2024 at 04:13:00PM -0600, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4654 > > In preparation for running under an SVSM at VMPL1 or higher (higher > numerically, lower privilege), re-organize the way a page state change > is performed in order to free up the GHCB for use by the SVSM support. > > Currently, the page state change logic directly uses the GHCB shared > buffer to build the page state change structures. However, this will be > in conflict with the use of the GHCB should an SVSM call be required. > > Instead, use a separate buffer (an area in the workarea during SEC and > an allocated page during PEI/DXE) to hold the page state change request > and only update the GHCB shared buffer as needed. So the idea is that the lowlevel code takes the "page state change request", then either writes the request to the GHCB when running in vmpl == 0 (this patch), or submits a SVSM call when running in vmpl > 0 (somewhere later in this series I guess)? > Since the information is copied to, and operated on, in the GHCB shared > buffer this has the added benefit of not requiring to save the start and > end entries for use when validating the memory during the page state > change sequence. The patch is pretty large, I'm not sure it is possible to make it much smaller though. > - i = 0; > + Index = 0; That rename can be splitted. Will be a rather small chunk though. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114700): https://edk2.groups.io/g/devel/message/114700 Mute This Topic: https://groups.io/mt/103986437/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-