From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ngompa13@gmail.com
Cc: michael.d.kinney@intel.com
Subject: Re: [edk2-devel] GitHub PR Code Review process now active
Date: Tue, 4 Jun 2024 15:23:02 +0200 [thread overview]
Message-ID: <dqtkxdwrz3t2v6nmhzbdolcwdmrlgbdbp7wqvfwxsjkcaprvno@j2ih2lotgp5w> (raw)
In-Reply-To: <CAEg-Je_g=Ghm3f4XAjzub-6TvGUNkLQcOCS6Zs5Pyf-R51D9uw@mail.gmail.com>
On Mon, Jun 03, 2024 at 02:46:30PM GMT, Neal Gompa wrote:
> That said, draft PRs cannot be reviewed, so we should not be telling
> people to make draft PRs.
It makes sense to open draft PRs, work in the PR until CI is clean,
only then flip the PR to 'ready' and bother maintainers to review.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119447): https://edk2.groups.io/g/devel/message/119447
Mute This Topic: https://groups.io/mt/106355103/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-06-04 13:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 18:53 [edk2-devel] GitHub PR Code Review process now active Michael D Kinney
2024-05-29 6:38 ` Gerd Hoffmann
2024-05-29 15:00 ` Michael D Kinney
2024-05-29 16:38 ` Gerd Hoffmann
2024-05-29 18:09 ` Michael D Kinney
2024-05-29 18:18 ` Rebecca Cran
2024-05-29 18:27 ` Michael D Kinney
2024-05-29 19:25 ` Michael Kubacki
2024-05-29 20:06 ` Michael D Kinney
2024-05-30 0:51 ` Michael Kubacki
2024-05-30 17:38 ` Saloni Kasbekar
2024-05-30 18:00 ` Michael D Kinney
2024-05-31 3:50 ` Michael D Kinney
2024-05-31 4:36 ` Michael Kubacki
2024-06-21 5:15 ` Dhaval Sharma
2024-06-21 5:25 ` Michael D Kinney
2024-05-30 8:32 ` Gerd Hoffmann
2024-05-30 14:10 ` Michael D Kinney
2024-05-29 10:40 ` Chang, Abner via groups.io
2024-05-29 14:44 ` Michael D Kinney
2024-05-29 14:48 ` Chang, Abner via groups.io
2024-05-30 0:41 ` Yao, Jiewen
2024-06-03 16:13 ` Neal Gompa
2024-06-03 16:26 ` Michael D Kinney
2024-06-03 18:46 ` Neal Gompa
2024-06-03 19:38 ` Michael D Kinney
2024-06-05 22:21 ` Michael D Kinney
2024-06-05 22:47 ` Rebecca Cran via groups.io
2024-06-05 23:27 ` Michael D Kinney
2024-06-16 22:08 ` Rebecca Cran
2024-06-06 1:21 ` Guo Dong
2024-06-06 1:37 ` Michael D Kinney
2024-06-04 13:23 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dqtkxdwrz3t2v6nmhzbdolcwdmrlgbdbp7wqvfwxsjkcaprvno@j2ih2lotgp5w \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox