From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 79424D8119E for ; Tue, 4 Jun 2024 13:23:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YkXg57ZtIFoeLA8FEedSqky302kI1eRVR5sJtEI0vRs=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1717507389; v=1; b=V/iXIr5BbY9RQUgwtYwBAPQNLFiTKIoGzuNcap+JBUrjnPN9B5pM1AWj78nut7dsFz9zdqSm IGHmbLF2ckO42tRV4+Onh3qetaeEwDi6dVmEaXHzk8MYRJEBnWC+4qk0bNrHkp1caZj2msAKo4w kKdsradaVglgUY+ZQda9Af7ePg7pn0c2tMzMfvIf71aFMSjZQGFG3K4LWyFNERSS9XUfltyUUtm icfYg2bVfECCSBgezJd12tEnIhCbKFr9T/pOWsMuA65N6qBLWCB826sEecWbKF7YKCPzqKJceUp gwJ2tyDI4T1Lwo+i1Ty9L1a6lYI077G59zxYVdHHgfYIg== X-Received: by 127.0.0.2 with SMTP id w5hJYY7687511x6pl3LItOPC; Tue, 04 Jun 2024 06:23:08 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.21451.1717507387203239042 for ; Tue, 04 Jun 2024 06:23:07 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-M0_cY8m2MkCMU_-ry9eaqg-1; Tue, 04 Jun 2024 09:23:04 -0400 X-MC-Unique: M0_cY8m2MkCMU_-ry9eaqg-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 382051C05130; Tue, 4 Jun 2024 13:23:04 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 033E7C15C12; Tue, 4 Jun 2024 13:23:03 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id ED3A4180098E; Tue, 4 Jun 2024 15:23:02 +0200 (CEST) Date: Tue, 4 Jun 2024 15:23:02 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, ngompa13@gmail.com Cc: michael.d.kinney@intel.com Subject: Re: [edk2-devel] GitHub PR Code Review process now active Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 04 Jun 2024 06:23:07 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: yO5MCWR0TgrtILzJhNvbD6TXx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="V/iXIr5B"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Mon, Jun 03, 2024 at 02:46:30PM GMT, Neal Gompa wrote: > That said, draft PRs cannot be reviewed, so we should not be telling > people to make draft PRs. It makes sense to open draft PRs, work in the PR until CI is clean, only then flip the PR to 'ready' and bother maintainers to review. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119447): https://edk2.groups.io/g/devel/message/119447 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-