From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C89999413CA for ; Mon, 11 Sep 2023 11:27:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZaQWU8o/Xmu2wCEgkAsbW5rcL6ea958OikihEYuCXJk=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1694431670; v=1; b=NCaReLo0Op1ZLbxeQIPG7zlp4jxts47NqRid1jK0AMOGP4t/Fyd6kojBjYtOBUM66QPIFytO 260sCfQhrvSBC5ZuK1a+7IvoMXtgn7xUep3GIxR50RKgglpZ+6byyvSPnPK9YtE2tO4yY1K7OS+ 5OEcV7QIBQ9/nhocEcZinWrE= X-Received: by 127.0.0.2 with SMTP id qaF8YY7687511xsBi8nO0QWL; Mon, 11 Sep 2023 04:27:50 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.56134.1694431669748139375 for ; Mon, 11 Sep 2023 04:27:49 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-kqHcls3LOACqqZFrJqW5BQ-1; Mon, 11 Sep 2023 07:27:45 -0400 X-MC-Unique: kqHcls3LOACqqZFrJqW5BQ-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 055F89362AF; Mon, 11 Sep 2023 11:27:45 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.193.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC6242156701; Mon, 11 Sep 2023 11:27:44 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 585B51800850; Mon, 11 Sep 2023 13:27:43 +0200 (CEST) Date: Mon, 11 Sep 2023 13:27:43 +0200 From: "Gerd Hoffmann" To: Taylor Beebe Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Rebecca Cran , Peter Grehan , Corvin =?utf-8?B?S8O2aG5l?= Subject: Re: [edk2-devel] [PATCH v3 21/26] OvmfPkg: Enable Choosing Memory Protection Profile via QemuCfg Message-ID: References: <20230830231851.779-1-taylor.d.beebe@gmail.com> <20230830231851.779-22-taylor.d.beebe@gmail.com> MIME-Version: 1.0 In-Reply-To: <20230830231851.779-22-taylor.d.beebe@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3PYHvsnC9C6SBjLePPo2GTSdx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NCaReLo0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, > .../PeilessStartupLib/PeilessStartup.c | 60 +++++++++++++-- > OvmfPkg/PlatformPei/Platform.c | 74 +++++++++++++------ Can we move that code to a library so we don't add it twice to the code base and also make it easier to reuse it for ArmVirtQemu? See OvmfPkg/Library/TlsAuthConfigLib for example. > +RETURN_STATUS > +EFIAPI > +QemuFwCfgParseString ( > + IN CONST CHAR8 *FileName, > + IN OUT UINTN *BufferSize, > + OUT CHAR8 *Buffer > + ) > +{ > + return QemuFwCfgGetAsString (FileName, BufferSize, Buffer); > +} Separate patch please. > - gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack Dropping that PCD can also go to a separate patch. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108484): https://edk2.groups.io/g/devel/message/108484 Mute This Topic: https://groups.io/mt/101064096/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-