From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26C8F1A1E08 for ; Fri, 2 Sep 2016 12:23:47 -0700 (PDT) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0FA57C057FAC; Fri, 2 Sep 2016 19:23:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.phx2.redhat.com [10.3.116.76]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u82JNimX018721; Fri, 2 Sep 2016 15:23:45 -0400 To: Ard Biesheuvel References: <1472840159-28957-1-git-send-email-ard.biesheuvel@linaro.org> From: Laszlo Ersek Cc: edk2-devel@ml01.01.org Message-ID: Date: Fri, 2 Sep 2016 21:23:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472840159-28957-1-git-send-email-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 02 Sep 2016 19:23:46 +0000 (UTC) Subject: Re: [PATCH v3 0/6] ArmVirtQemu: move to generic PciHostBridgeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 19:23:47 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/02/16 20:15, Ard Biesheuvel wrote: > Now that Laszlo's virtio-gpu-pci series has removed the last remaining obstacle, > we can get rid of the special PciHostBridgeDxe implementation in ArmVirtPkg, > and move to the generic one. On AArch64, this will allow us to perform DMA above > 4GB without bounce buffering, and use 64-bit MMIO BARs allocated above 4 GB. > > Changes since v2: > - use legacy ACPI id (0x0A03) rather than PCIe (0x0A08) > - disable DMA above 4 GB, this requires fixes in the PciHostBridgeDxe driver > and in many PCI drivers in the EDK2 > - set EFI_PCI_HOST_BRIDGE_MEM64_DECODE only if the MMIO64 region has non-zero > size > - minor tweaks > - add Laszlo's acks to the remaining patches, all patches are acked now > > Branch can be found here: > https://git.linaro.org/people/ard.biesheuvel/uefi-next.git/shortlog/refs/heads/qemu-pci I compared each v3 patch against its v2 counterpart, including the commit messages. The changes look right. Also, I tested the series, with special regard to the USB 2 keyboard in the firmware, and QemuBootOrderLib's behavior -- everything works fine. Just to be sure, I booted the F24 guest as well, with Xfce. Success. Series Tested-by: Laszlo Ersek Please go ahead and commit it! :) Thank you, Laszlo > Changes since v1: > - new patch #2 to move the IoTranslation discovery to FdtPciPcdProducerLib, > which is a cleaner approach since other drivers (i.e., ArmPciCpuIo2Dxe) > depend on it as well > - add support for ARM, i.e., disable the 64-bit range in that case, since we > cannot access 64-bit MMIO BARs if they are allocated there > - use statically allocated PCI_ROOT_BRIDGE[] array of size 1 > - enable support for ISA and VGA I/O range decoding > - various other minor fixes based on Laszlo's review comments > - added ref links and Laszlo's acks where appropriate, i.e., where given and > where the version of the patch in this series does not deviate substantially > from the suggested version on which the preliminary ack was based > > Patch #1 removes the linux,pci-probe-only override which does more harm than > good now that we switched to virtio-gpu-pci, which does not expose a raw > framebuffer. > > Patch #2 extends FdtPciPcdProducerLib so that it also sets PcdPciIoTranslation, > which is required for the FdtPciHostBridgeLib implementation this series > introduces, but also for ArmPciCpuIo2Dxe, which produces EFI_CPU_IO2_PROTOCOL > on which the generic PciHostBridgeDxe depends as well. > > Patch #3 implements PciHostBridgeLib for platforms exposing a PCI host bridge > using a pci-host-ecam-generic DT node. The initial version is based on the > ArmVirtPkg implementation of PciHostBridgeDxe, so it does not support 64-bit > MMIO BARs allocated above 4 GB, but it does support DMA above 4 GB without > bounce buffering. > > Patch #4 switches to the generic PciHostBridgeDxe, with no change in > functionality other than support for DMA above 4 GB without bounce buffering. > > Patch #5 adds support for allocating 64-bit MMIO BARs above 4 GB. > > Patch #6 removes the now obsolete PciHostBridgeDxe from ArmVirtPkg. > > > Ard Biesheuvel (6): > ArmVirtPkg/PciHostBridgeDxe: don't set linux,pci-probe-only DT > property > ArmVirtPkg/FdtPciPcdProducerLib: add handling of PcdPciIoTranslation > ArmVirtPkg: implement FdtPciHostBridgeLib > ArmVirtPkg/ArmVirtQemu: switch to generic PciHostBridgeDxe > ArmVirtPkg/FdtPciHostBridgeLib: add MMIO64 support > ArmVirtPkg: remove now unused PciHostBridgeDxe > > ArmVirtPkg/ArmVirtQemu.dsc | 10 +- > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +- > ArmVirtPkg/ArmVirtQemuKernel.dsc | 10 +- > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 436 ++++ > ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf | 57 + > ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c | 108 +- > ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf | 2 + > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c | 1496 -------------- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h | 499 ----- > ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf | 64 - > ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c | 2144 -------------------- > 11 files changed, 613 insertions(+), 4216 deletions(-) > create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c > create mode 100644 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.c > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridge.h > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciHostBridgeDxe.inf > delete mode 100644 ArmVirtPkg/PciHostBridgeDxe/PciRootBridgeIo.c >