From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 685F2222DE12B for ; Wed, 7 Feb 2018 16:29:57 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63F564E334; Thu, 8 Feb 2018 00:35:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-123.phx2.redhat.com [10.3.117.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id C09E160BE0; Thu, 8 Feb 2018 00:35:39 +0000 (UTC) To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Cc: Sean Brogan , "Yao, Jiewen" , "Justen, Jordan L" , Ard Biesheuvel References: <20180207225822.28876-1-michael.d.kinney@intel.com> <20180207225822.28876-6-michael.d.kinney@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 8 Feb 2018 01:35:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 08 Feb 2018 00:35:41 +0000 (UTC) Subject: Re: [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 00:29:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/08/18 00:48, Kinney, Michael D wrote: > Laszlo, > > The BmpSupportLib content was from contributions from > a capsule related branch. However, the BmpSupportLib > can be used for UX capsules as well as other places that > conversions between BMP and GOP BLT buffers are needed, > so it is a more generic feature. The SafeIntLib was also > based on content from the same capsule related branch but > also has uses other than capsules. > > Yes. I need to add Signed-off-by for Sean. OK, with the S-o-b updated, for patches #5 and #10: Reviewed-by: Laszlo Ersek Thank you, Laszlo > Thanks for the "xfuncname" tip. I will add that to my > notes for sending patch emails so it is always enabled. > > Mike > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, February 7, 2018 3:17 PM >> To: Kinney, Michael D ; edk2- >> devel@lists.01.org >> Cc: Sean Brogan ; Yao, Jiewen >> ; Justen, Jordan L >> ; Ard Biesheuvel >> >> Subject: Re: [Patch 05/10] OvmfPkg: Add SafeIntLib and >> BmpSupportLib to DSC files >> >> Hi Mike, >> >> On 02/07/18 23:58, Kinney, Michael D wrote: >>> From: Michael D Kinney >>> >>> https://bugzilla.tianocore.org/show_bug.cgi?id=800 >>> >>> Based on content from the following branch/commits: >>> >> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsule >> Support >>> >> https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417 >> d7d5a7d356c15a14c2e60302b2d >>> >> https://github.com/Microsoft/MS_UEFI/commit/ca516b1a61315 >> c2d823f453e12d2135098f53d61 >>> >> https://github.com/Microsoft/MS_UEFI/commit/2b9f111f2e74a >> 4c2ef4c4e32379e111f016dbd9b >> >> These commits look capsule-related, but the paragraph >> below speaks about >> BootGraphicsResourceTableDxe and image format conversion. >> Should the >> references be updated? >> >> Also, if part of the code is from Sean, do we need an S- >> o-b from him, >> above yours? >> >> The DSC file changes look fine; I'm ready to R-b once the >> above is >> clarified. >> >> (For the future, please consider the "xfuncname" setting >> from >> > szlo's-unkempt-git-guide-for-edk2-contributors-and- >> maintainers#contrib-05>, >> together with >> > szlo's-unkempt-git-guide-for-edk2-contributors-and- >> maintainers#contrib-09>. >> >> Those settings help with the review of DSC and similar >> files -- the @@ >> hunk headers in the patch will state the [LibraryClasses] >> file section, >> for example.) >> >> Thanks, >> Laszlo >> >>> The BootGraphicsResourceTableDxe module uses the >> BmpSupportLib >>> and SafeIntLib to convert a GOP BLT buffer to a BMP >> graphics image. >>> Add library mappings for these new library classes. >>> >>> Cc: Sean Brogan >>> Cc: Jiewen Yao >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Michael D Kinney >> >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 2 ++ >>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ >>> OvmfPkg/OvmfPkgX64.dsc | 2 ++ >>> 3 files changed, 6 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc >> b/OvmfPkg/OvmfPkgIa32.dsc >>> index d762955c5d..e10f898607 100644 >>> --- a/OvmfPkg/OvmfPkgIa32.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32.dsc >>> @@ -104,6 +104,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc >> b/OvmfPkg/OvmfPkgIa32X64.dsc >>> index 6bcbe70d64..a31c7919ad 100644 >>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc >>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc >>> @@ -109,6 +109,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> diff --git a/OvmfPkg/OvmfPkgX64.dsc >> b/OvmfPkg/OvmfPkgX64.dsc >>> index 70fcdcba11..bc433a9724 100644 >>> --- a/OvmfPkg/OvmfPkgX64.dsc >>> +++ b/OvmfPkg/OvmfPkgX64.dsc >>> @@ -109,6 +109,8 @@ >>> >> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >>> >> BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemo >> ryLibRepStr.inf >>> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >>> + >> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i >> nf >>> + >> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base >> BmpSupportLib.inf >>> >> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/ >> BaseSynchronizationLib.inf >>> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf >>> >> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base >> PerformanceLibNull.inf >>> >