From: "Tomas Pilar (tpilar)" <tpilar@solarflare.com>
To: <devel@edk2.groups.io>, <mcb30@ipxe.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-devel] iSCSI and iBFT
Date: Thu, 23 May 2019 10:46:30 +0100 [thread overview]
Message-ID: <e066fc1a-93ef-69eb-a9c5-c116418ccb64@solarflare.com> (raw)
In-Reply-To: <006adde9-25fd-bdd8-1bda-bbea4302e777@ipxe.org>
I was mostly puzzled by the double step. First find a parent device to LoadedImage that support NII. Rather than using that device we will scan all devices to see if any of them has the same NII protocol and if so we use that one. I am not sure there is any advantage compared to just using the original parent device?
In either way, the device path search using NII is fairly ingenious!
On 22/05/2019 23:26, Michael Brown wrote:
> On 22/05/2019 11:40, Tomas Pilar (tpilar) wrote:
>> Yeah, I just AllocateCopyPool the static struct on heap for each device. I can honestly see how one would assume that a protocol instance would never be installed on more than one handle, same as I assumed that using a statically allocated struct containing nothing but boilerplate info would also be fine.
>>
>> The whole NII and UNDI drivers vs. SNP drivers compatibility across OEMs/IBVs and IHVs is a painful trash fire and this is just the last problem in a very long line of annoyances. </rant>
>
> Thanks for writing up the end result. I can't immediately see any more viable way for iPXE to determine the NII corresponding to the user's concept of "the NIC from which I booted", but I'm open to suggestions.
>
> Thanks again,
>
> Michael
>
>
>
next prev parent reply other threads:[~2019-05-23 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 15:56 iSCSI and iBFT Tomas Pilar (tpilar)
2019-05-21 14:54 ` Tomas Pilar (tpilar)
2019-05-21 19:47 ` [edk2-devel] " Laszlo Ersek
2019-05-22 9:55 ` Tomas Pilar (tpilar)
2019-05-22 10:19 ` Laszlo Ersek
2019-05-22 10:40 ` Tomas Pilar (tpilar)
2019-05-22 22:26 ` Michael Brown
2019-05-23 9:46 ` Tomas Pilar (tpilar) [this message]
2019-05-23 10:35 ` Michael Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e066fc1a-93ef-69eb-a9c5-c116418ccb64@solarflare.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox