From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C42D581EF9 for ; Thu, 17 Nov 2016 11:48:37 -0800 (PST) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0A1765729; Thu, 17 Nov 2016 19:48:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-6.phx2.redhat.com [10.3.116.6]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAHJmfqb002622; Thu, 17 Nov 2016 14:48:42 -0500 To: Michael Kinney , edk2-devel@ml01.01.org References: <1479411282-10996-1-git-send-email-michael.d.kinney@intel.com> From: Laszlo Ersek Message-ID: Date: Thu, 17 Nov 2016 20:48:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1479411282-10996-1-git-send-email-michael.d.kinney@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 17 Nov 2016 19:48:42 +0000 (UTC) Subject: Re: [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Nov 2016 19:48:37 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/17/16 20:34, Michael Kinney wrote: > Updates for V2 > ============== > * Split out patch that corrects function names in comment blocks > * Change InterlockedCompareExchangePointer() parameter from volatile VOID** > to VOID * volatile *. > * Remove unnessary typecast in calls to InterlockedCompareExchangePointer() > * Fix missing copyright updates > * Minor formatting changes > > Michael Kinney (3): > MdePkg/Include: Add volatile to SynchronizationLib parameters > MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs > MdePkg/BaseSynchronizationLib: Fix function names in function headers > > MdePkg/Include/Library/SynchronizationLib.h | 14 +++++++------- > .../Ia32/InterlockedCompareExchange16.asm | 4 ++-- > .../Ia32/InterlockedCompareExchange16.c | 4 ++-- > .../Ia32/InterlockedCompareExchange16.nasm | 4 ++-- > .../Ia32/InterlockedCompareExchange32.asm | 4 ++-- > .../Ia32/InterlockedCompareExchange32.c | 4 ++-- > .../Ia32/InterlockedCompareExchange32.nasm | 4 ++-- > .../Ia32/InterlockedCompareExchange64.asm | 4 ++-- > .../Ia32/InterlockedCompareExchange64.c | 4 ++-- > .../Ia32/InterlockedCompareExchange64.nasm | 4 ++-- > .../BaseSynchronizationLib/Ia32/InterlockedDecrement.asm | 4 ++-- > .../BaseSynchronizationLib/Ia32/InterlockedDecrement.c | 4 ++-- > .../Ia32/InterlockedDecrement.nasm | 4 ++-- > .../BaseSynchronizationLib/Ia32/InterlockedIncrement.asm | 4 ++-- > .../BaseSynchronizationLib/Ia32/InterlockedIncrement.c | 4 ++-- > .../Ia32/InterlockedIncrement.nasm | 4 ++-- > MdePkg/Library/BaseSynchronizationLib/Synchronization.c | 16 ++++++++-------- > .../Library/BaseSynchronizationLib/SynchronizationGcc.c | 16 ++++++++-------- > .../Library/BaseSynchronizationLib/SynchronizationMsc.c | 16 ++++++++-------- > .../X64/InterlockedCompareExchange16.asm | 6 +++--- > .../X64/InterlockedCompareExchange16.c | 4 ++-- > .../X64/InterlockedCompareExchange16.nasm | 6 +++--- > .../X64/InterlockedCompareExchange32.asm | 6 +++--- > .../X64/InterlockedCompareExchange32.c | 4 ++-- > .../X64/InterlockedCompareExchange32.nasm | 6 +++--- > .../X64/InterlockedCompareExchange64.asm | 6 +++--- > .../X64/InterlockedCompareExchange64.c | 4 ++-- > .../X64/InterlockedCompareExchange64.nasm | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedDecrement.asm | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedDecrement.c | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedDecrement.nasm | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedIncrement.asm | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedIncrement.c | 6 +++--- > .../BaseSynchronizationLib/X64/InterlockedIncrement.nasm | 6 +++--- > 34 files changed, 103 insertions(+), 103 deletions(-) > series Reviewed-by: Laszlo Ersek