From: Laszlo Ersek <lersek@redhat.com>
To: Heyi Guo <heyi.guo@linaro.org>, edk2-devel@lists.01.org
Cc: Ruiyu Ni <ruiyu.ni@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [RFC v2 0/2] Add translation support to generic PCIHostBridge
Date: Thu, 22 Feb 2018 11:06:13 +0100 [thread overview]
Message-ID: <e0b4f828-71b8-741e-4bbe-733ae1d52792@redhat.com> (raw)
In-Reply-To: <1519282474-94811-1-git-send-email-heyi.guo@linaro.org>
On 02/22/18 07:54, Heyi Guo wrote:
> v2:
> Changs are made according to the discussion on the mailing list, including:
>
> 1. PciRootBridgeIo->Configuration should return CPU view address, as well as
> PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view
> address - CPU view address.
> 3. PciHostBridge driver internally used Base Address is still based on PCI view
> address, and translation offset = CPU view - PCI view, which follows the
> definition in ACPI, and not the same as that in UEFI spec.
I find these opposite interpretations incredibly confusing. My review
for v2 1/2, point (1) namely, is likely wrong because of this.
This information absolutely needs to go into the commit message of patch
#1, and also into the code as comments.
Thanks
Laszlo
next prev parent reply other threads:[~2018-02-22 10:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 6:54 [RFC v2 0/2] Add translation support to generic PCIHostBridge Heyi Guo
2018-02-22 6:54 ` [RFC v2 1/2] MdeModulePkg/PciHostBridgeDxe: Add support for address translation Heyi Guo
2018-02-22 8:55 ` Ni, Ruiyu
2018-02-22 8:56 ` Ni, Ruiyu
2018-02-22 9:43 ` Laszlo Ersek
2018-02-22 6:54 ` [RFC v2 2/2] MdeModulePkg/PciBus: return CPU address for GetBarAttributes Heyi Guo
2018-02-22 10:41 ` Laszlo Ersek
2018-02-23 1:10 ` Guo Heyi
2018-02-22 10:06 ` Laszlo Ersek [this message]
2018-02-22 10:32 ` [RFC v2 0/2] Add translation support to generic PCIHostBridge Guo Heyi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b4f828-71b8-741e-4bbe-733ae1d52792@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox