From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.42]) by mx.groups.io with SMTP id smtpd.web12.239.1634242268068668665 for ; Thu, 14 Oct 2021 13:11:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=XkPFDODw; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.42, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4RTxyZRWFVt+4L6mvKilqjen/3gCVXfezT9zz2xwcldklzIRjBrWhY1Cnsi3RYMbaZuCWmnhn7EhutlkUcpn6nRGEvNZ84e/GUI1q1Fgsj/nUwjDIroose84boA+/AKq6h3dSAXK1kAWwc0N1dHrLxcK5jl7OlbU0FqRMdii4U8ml8jWwPw5I4osmrzO1XkZ3m03i9VnWBXFoIu9oVXhw8t/ALd316OW87e9UJDL3cMs/f5wkBPDSTm/rkEFL44w1A5J16TFtKPUYBwIR6fel9fJyqAsYgJjd7CP6vkmprEiFlArqhY+/O1RQVp7LC9g/0BqiphZ4PL/g7Agn/gXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9dZcwPrYZWQva5N0GQtWU8ZcKDbDNsaZwsXFsae/03w=; b=TCJff3zrNnn6lgS7Su0AtS2dY7ynefsxgt76FnoIoatfam/5D+2f7reRZJATk+5qw1Wi0/70lu+5ifeaBGwLK5/CBoiC36Fv3RglIR5KeRmYXvVLdxEW14yWjjIirTDtBR9Ijey0xvRivC2cf2BlKHjjnTXTDXWsUASDGL+4fxFMJ2v6wy60OhVmXo9c2hlMiHyw2FbnQNNjyyAtIVyGUuO5gwH1vs9iKMMXzKe7smpFwv0yMgzf1V7PaDdlIbMZIoH+xF8oRsWmjbw3SJAZwXHj7CEGu5qzSaFZzydBWstOH7f+db8Pmsa5HlWJxAZxtnpI6unoEuAFJE9U/WCBAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9dZcwPrYZWQva5N0GQtWU8ZcKDbDNsaZwsXFsae/03w=; b=XkPFDODwwv4Fl8kf96Q/pDUUccHYXr8r9ZtDL+WtbjBAPv05EJ9QTb8JTWWWOacsIa/0oDy1ar20nLt0wJSgfiqHeSvaAVKmpIlpx73Awa0MBXtg26JRKTbHfNOXUdabcxyWw7r8JhS3Y9d6ZcFLuOgyxixJS9s59L/TfNTBZmM= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4430.namprd12.prod.outlook.com (2603:10b6:806:70::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Thu, 14 Oct 2021 20:11:06 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 20:11:06 +0000 Cc: brijesh.singh@amd.com, devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth , Ray Ni , Rahul Kumar , Eric Dong Subject: Re: [PATCH v9 20/32] UefiCpuPkg: Define ConfidentialComputingGuestAttr To: Gerd Hoffmann References: <20211013165713.727815-1-brijesh.singh@amd.com> <20211013165713.727815-21-brijesh.singh@amd.com> <20211014083836.ivmb6ag63kyin5e2@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: Date: Thu, 14 Oct 2021 15:11:00 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20211014083836.ivmb6ag63kyin5e2@sirius.home.kraxel.org> X-ClientProxiedBy: SA9P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::29) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.78.25) by SA9P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Thu, 14 Oct 2021 20:11:03 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23c5a95d-3caa-46a1-6679-08d98f4ec108 X-MS-TrafficTypeDiagnostic: SA0PR12MB4430: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dXbWWHSn0QqqtjRb03ufNxEqgfYh4p0rSnj5F7G+91vnZ65f0NdCLrq3uMwlSxNeE5ks3l4UG4pObswtABaarmYI6Y7RfVdJ8iTrMa/D8ZM/Io4MeBipBQ+lIQmofU8Tq9Z4iaDNkdeMziwUttAG8M6QuG2OhtrQaZlDY6XTFeQEuOlAobLbIAo2Seo3d6dn7EhcSDOZxn6OIFRSrpViO+SGs4b5x6fqPOrY69NLs05PNTD8Rf5haoVwdIe+WyOjGK3s5ArQhSDKU2G6rugEF0UAIgakpwzvKnNGsSjyM8lZae48datIf9cAe5w2tJjlJhLajcLsgqy7VudMKY3kW9VUIiqqgXOsp6r0dPSjQLRUsA02CD/utckMcLBInz3c/CHssRpZQ1qekMTsNzq5eL7w/6bB6tBL/4xcs1eiQR2eoyXqUufFaLwR7V9G0o2gr3TSVU12nvqF1SL6KfAiVYsUajbSac1enQx/hqoq7QpCgE35ntPrh/UcR1m+cbWpJWhTjnmmGEBrC8V4NCFvRBszGvxScrxBPl4VCMXCt6QCV+dzG5lEFngzcUfmu2/UMRciI75hb+NDy2TsK/IK//VvcPBX2zeAxdVT8b5aqJE0TYEtAhGMXMyZI5KOIOAFm/kF0IhKGa61EuwsaUEjCA0pIMuZA5gd6e7EZUarvM2eEq1+QSGNxc5gG3piZWsMo2d0UTsqHu/tks6smCB0vbUOmutMl1QGDq8OpOKQXRwXtmvm+Yv0JMyjoI+E0GXQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(53546011)(956004)(7416002)(26005)(2616005)(8936002)(4326008)(44832011)(6916009)(38100700002)(31696002)(6506007)(508600001)(4744005)(6512007)(36756003)(8676002)(316002)(6486002)(2906002)(5660300002)(66946007)(66556008)(86362001)(66476007)(31686004)(186003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aEwySEw4dmIyUXg2aDhTdlBJbjAzcEVrK0dLbnJUUzVFbHVudXlHb3luUlpv?= =?utf-8?B?aEhPaUMzemQzSVRhZGEvd2RTK2gyQjJpOUVWdHhlUEU4cEhIaFF5RjM0TDJn?= =?utf-8?B?ODQ1TzloNmFRMjNzYklOK1VCUWxIdmpxTXViUjVuN242VXZqYWVZNmFNSHpG?= =?utf-8?B?YmxsY1BqUkE5SEhBY0xqQU8xZ1RsZHAvM3Fta0psYzVXWGZNcWM4SUFDMU1D?= =?utf-8?B?NjhNbGlxS3JBZ3dsZjlya0RDSSthMW9jNEc4YmZ0MnJ3aUJoaFJFRGJWd2xU?= =?utf-8?B?M3dUQmYzN2F5SmhUdTljd3Y5NWFIazBhYzJ3K2tWZkt6c2FBbWJkaHhmVDd5?= =?utf-8?B?Zzh0S256dnQyL01GVGtyd09hWHJYdUJUZThtc2s0aEl6a08zR1JQQmhVVzZi?= =?utf-8?B?RlBLMVJ1a2R3T29odytXTy9qTzFUVSt1Z2pyR2xGSFlsRWNHRWlVaUppY0Rj?= =?utf-8?B?cUpoUWtlSXIwVS9Vd09uMHFiOVcxY2ZiU21VUmVNUGhTYTBNL2ZyVVFTYXVv?= =?utf-8?B?QnozVU91S2lEUzJ1U2NETHByeDFCMVhwMXVSNzBoQmF0bEVVZ0F0cThqMmRO?= =?utf-8?B?Z2JXWVhSVDhaSXVYWUw0Wjd1RjJqRmpoSElmc3FBSk1KeWRNckxnVEozZjRH?= =?utf-8?B?KzRDWm5UZ3BuaFJsUWZzS3lIZjh5YUdBVVFsN3JQcEZWakcvT1ZJQ1NqNVdq?= =?utf-8?B?K011N1k2Nm5ZVXo0OTBOc284ZjAvd0hLMmR6c0xvOU1kVHptK3VmdzJ6YTRs?= =?utf-8?B?WGhrcjB6R3F6RjJLR0xkRjRmbVpkaWtsSWlzMm1RNlY4T3NrWHkrZW9Cc3I4?= =?utf-8?B?Y2xoQ09KTkx3dmR5UWdRRVI3dEVOemVzcVdBTERvcElSVUhXTHVTSFQ5bW1P?= =?utf-8?B?YUlFazNtc2dZOVYwL0JZczRWYTNoUFJjR2QxMDExbHBRM3F1akFBUTQxeVEr?= =?utf-8?B?Z2s4V0FqVWxKOWZNUzRXVjlJOUM4S3cyODdOU3VObjEyaUxNU2VBM2VvcWNW?= =?utf-8?B?c2hma2hIcUxBbGFRSkpuWEVWTEcrSS9wSDVHWDF3Tno1MC9jd29PcVFkZmxL?= =?utf-8?B?TStDbGVueDA1VUhIM2lPRlp3SHB4cXRqeHRadGI5UmpUZGRmYUplaEZGMy9h?= =?utf-8?B?Uk5hM3RPN1V6UE5neTdjVmhLSTJpSGFVS1ltQkZsWHpsdzQ3cHA5RCthUnAx?= =?utf-8?B?U3dBN2tUdzhwME5WR0NERUxyQTZISXZud3ZvcmhIM2VsTjQ5YWZZTUowMnR0?= =?utf-8?B?K2RLOUJ0dFlEVUtQZ1hTSURYajJMcGIrcFhGanhRbVVCWU0vV3Y0YUVmUWFD?= =?utf-8?B?MGw5UytCdndUdXkxSkVJczBlK0VrbWs1T3RGWjdCQkROZlQ0T2tLWWFMcERM?= =?utf-8?B?WEgreVBiU0ZRKzcwTEpDZnFGc0I0MERCY1dXU2REWjNEOExJcFhjZWFteG1D?= =?utf-8?B?YWxuOFUzUWV2QjRIbmZrUzNSSVcyL28zVnJpUHNSTTZxUXp0MVlDamlxS2xO?= =?utf-8?B?aE5weWJBOGZzTmtSbW56eUM3WkVROFRpRlUzRmVYYVNSaWlSVTFvWEdYaUcy?= =?utf-8?B?OXpRbzMvSG1vb2FVY3UrUjR5Q2ZCUWdlQnVQZEFEek9ESnpGUUVDbFRPZjhJ?= =?utf-8?B?L0tSZkNoa1JRSVpXNGttdWlPMWFZZGliMlkrQ0tkVUFEVEdBTkc1bVlFQkxm?= =?utf-8?B?VmpYK1pBVytWZVJ1U1o1QkdnMDRUUk1pUVU2WUIxeTJmYUxHZExvNFluVll1?= =?utf-8?Q?vuxRt3jStwn2QdIUF0p3amnv/Y6GXdH1PbSxl1L?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23c5a95d-3caa-46a1-6679-08d98f4ec108 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 20:11:06.0269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VVyBc/x8bo2T/+Oe6NKCvt79X90g4UXJB5b21U2DeIb4SHGb+wVBSD7GPtWrAlesQjEd/cSsX4+h8Osc9mXm+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4430 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 10/14/21 1:38 AM, Gerd Hoffmann wrote: > Hi, > >> + ## This dynamic PCD indicates the memory encryption attribute of the guest. >> + # @Prompt Memory encryption attribute >> + gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x60000017 > See discussion in parallel thread. This is probably not the best place > for the PCD due to dependency problems which make the PCD less useful > than it should. There is more code than just cpu which must be tsx/sev > aware. > > Move to MdePkg? Yes, I think that will work. For SEV case so far there was no need for to move in MdePkg so I kept in UefiCpuPkg but I am good with moving. > take care, > Gerd >