From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.46]) by mx.groups.io with SMTP id smtpd.web11.5881.1676379336205421774 for ; Tue, 14 Feb 2023 04:55:36 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=YwL1ryrf; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.46, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E0/G/Jg8F9U0Ay3Vk5SFsOq6X5MRKXQ2SEepq+rpKunMxPBv1bKqT6ywq4gTBAAWBegcUwrf8EoaH3qFm+kacSPZJvTEQrqM2hkWZNVY7Qsz3J5trdOAwf2eB0eFFJY7Vf/IpZUdPIgGhbl4HrfyVaWvGRJrzDNiksLCoA+EmFGUB5shOfNKieXg66S7kj+b7MXjf6LynrPP2d7toO+q3dqi86Domv3x9Hm7FZujyPPfTBw2I0UiTtFImYfMAwqutrAMLIOhtx9hIuG2/i651MkUhALqiy5aTbhd/l1+Z+Maz62GFwgZsyRSgtZDXXooyBFmR9gkw9S2tt6DsJ4mjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rI8yHW7VDE09n3KR+r2QxPeLUqL9Mn4uSJalTGFRxQY=; b=CPmFoa7khlv88+obY5tE/HXl5e3O9lmSCKKQHQeuAFIGffZiSvfgXpCp47u1VoaBsy9I74VSrYEn7JOoipuh/3qnQEqT2+FNZuWA7var59cR6lggFLPGALZALJCOe6lRIGCTyJPc/1eBRkmrOTZILhH3vDtql7p+zKFOJH3YXauF9FAMjhtmw4o2Q3s6x/E96O0IrJdQAOr9Bl+awuvGsDYzEa3e6bMRyIJNfMRJSgzUKdIK0+JZi/3j7NrvX9k0Dd2n7k/c389KyrgF8Ynr4zMwg21NoFMS+fqVHbGOg5XZ/JhE+wtWKIYZC8CdtJowGjaQVQi9+YG2rBxflKUNwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rI8yHW7VDE09n3KR+r2QxPeLUqL9Mn4uSJalTGFRxQY=; b=YwL1ryrfAgiCS9n7hbqibEg4rcx6GUqNauk01L/ne4IkcuZ5v6HYknZ3WTvQe0jGuWW7k/e6s+5zojfZgaEbQceFTw5w5SNr8BLJ+UEmHSn+pfgZOshstTDcqBslI/YvRyrFsh+1EMtSwDdVzjftCpJ6By3THx1Z18/unOeB58A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by CY5PR12MB6648.namprd12.prod.outlook.com (2603:10b6:930:42::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Tue, 14 Feb 2023 12:55:34 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.024; Tue, 14 Feb 2023 12:55:33 +0000 Message-ID: Date: Tue, 14 Feb 2023 13:55:26 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe From: "Gupta, Pankaj" To: Dionna Amalie Glaze CC: devel@edk2.groups.io, Gerd Hoffmann , James Bottomley , Jiewen Yao , Tom Lendacky , Ard Biesheuvel , "Min M. Xu" , Andrew Fish , "Michael D. Kinney" References: <20230126005647.3019225-1-dionnaglaze@google.com> <20230126005647.3019225-2-dionnaglaze@google.com> <0d8f2b0b-1d62-3db6-34c9-e9ce39838bce@amd.com> <9ea61013-e2c1-30a4-3be7-feed537c035a@amd.com> <52c7d139-3763-b4f2-ab5c-a0a925a1a3ff@amd.com> <39f4b07d-43ce-904c-991d-4789384c496c@amd.com> <9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com> In-Reply-To: <9a8e1ab8-c430-0a54-11be-581a2d9b6221@amd.com> X-ClientProxiedBy: FR2P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:93::20) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|CY5PR12MB6648:EE_ X-MS-Office365-Filtering-Correlation-Id: 0e88ffef-7e96-43fb-313c-08db0e8ac2a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +2R8Y74L5zL2A+L3naAXlwwUCEcQThkeLy/qK31uA2XuKBc67lE4DXeczmcpy9ArVbNp+buYFitrZStbCWr3U09Pr7x5wKH2t9DzSuJYMl/z+n4Irbb4WCWNYlIN6bcIOPPEBHtnb7QE7qDNyenLey8/pwMuenWj61CiOmrnx1IPto7J4zNK6r3BAtJpbBf5htKbLvLe5xP+J55vlNMCYxevyowqk+d0g2HoT8YwssJzmFyD1dotuvWlhoyRFmJQqGyNVDjuUEWqU1ScA/bDkv5E5KEBL27j5xZhIaXPh6iL/TPNRVe8/KzIIBev3Zp6VMxzd/PjMwaz5vSYN3bErbZ38hbbKIHMlDr3GYsxLtZSu5VUqVsEGws+vQ0B8PPCLYe2ohRXAIBnE1hK7ucjzPD9GnoshD3iAIlwJPSVCQlbmaUxtNbMEE+Cqxe16x4qbY6E83Ja5Y6FiYrO9YrKtHCj8bco+QdB6DUGjdN8Wh7t7oQRpu/9FrqSwGF6DXAHFjuRIYhX7PXjR2f14pCaf62ZFTkNDXK3qT/9AcKMFR7ceYS3rCVyf7QkgL50YnlDK8GC6vzrWzzvIA0k8f4OjCA9Z4K96NrIuaetf8+ajYg/ni3xxKGVHcjFHz2KlAnzwx6h375NcOgFJT0X9HQpxmPCxSa3ehRdr9TkmIfdAO9s/yJCbEOLhFTEmQsUkoR0s1FuCBGZPB14Xro1g6pVCGTG66kQc6A9SU59yXcGe8E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199018)(31686004)(478600001)(6666004)(2616005)(6506007)(53546011)(8676002)(6916009)(54906003)(6512007)(186003)(316002)(66476007)(66946007)(26005)(66556008)(83380400001)(6486002)(4326008)(36756003)(86362001)(41300700001)(8936002)(5660300002)(38100700002)(31696002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/CLcdR+X6YDn14H2hR+Mjz02DW71R6h1Jp/NUIgeF0Wg7Z0w/oy2WrZEuyIV?= =?us-ascii?Q?AR1WO6TUgEaT/tND3UQtvhF6Q8Je3U6vqoGFyRY7xX7yQF2z+LQ2dzSfYZ5M?= =?us-ascii?Q?jtBNu2klBhwYMn08wh4O4aXsgfN/vAIHJdh24Jzf+y4LI8GDiTnq84MjRQbh?= =?us-ascii?Q?f/+V+zYFXZFnFx2sLsIfhF1j16ubIfXgrhhkxzsuLN424kAqqJm/OPYwv/94?= =?us-ascii?Q?9jlAa+c+9QDQod2KYDhXRwPd5K1i6UFAGrICG50SXzugwftzTCVoHNyjOqA0?= =?us-ascii?Q?8CI+1DQB0TXtZir5r2iB6rYmzcwRN2Mlw8SegzjIUD0MDkk8cux6K/3EP1Ih?= =?us-ascii?Q?a7DuVeenH1ZLqrotY+3nsuZe8CwuCI6vn9fVCGMB3SdwNTPE1bIFOMdcS7O9?= =?us-ascii?Q?HwHogU6fckm24GsIKXaM6bpoFr/KukHhhbLwLGG4g3oqD0SpzSo4WvbxS0K5?= =?us-ascii?Q?WxE4jSfBQrtv5iKgJTLJATUYggcTT1LIDpOiANWl28MXiOn/ghWTZuBu5MAg?= =?us-ascii?Q?YQCV+aQ7TtmSEtf0s1MVChHsvySa8AALgnuEa9OsxVsqrVjqg7JpNkmzJzJR?= =?us-ascii?Q?lXqbboby5gGO1gnh/yO12QReffldDb+xo8NufDH6p8fUQsAaBnCgZ8yYK1x3?= =?us-ascii?Q?Bf770NKmQO7gyLan/OVMu/0qVaYls+L7baBELJxFHZJ5pG5yRT++X9g+yOxT?= =?us-ascii?Q?xQBHcsN+MFyubZ8rAdJdNVz/YJC8Ciev0QQ4Vx86Uqy4tyRj32EFgONfuV2Y?= =?us-ascii?Q?yVs1O3a55ywboJ1LhF3RlnhIBsqeZ+rhYke7M4Oddbxe1Kp+icCvM0PXRiq0?= =?us-ascii?Q?dZUHkx6S2eYhgdDTUSStH9trQ/EOAeEXWsNKCT7ih4Si/oOzvB5GJ046kPiM?= =?us-ascii?Q?JeT5kDdlV2FgnoByf3mdDA46qgzbZ5uN0kNbviyGbQesI7VeNlAGspKNKUYT?= =?us-ascii?Q?C7efFeQzGIhLFHCUQw+NvK3FPSNwiYGFAjPfeTqOutsdExuyC9v0r+/8mTq5?= =?us-ascii?Q?qixqWja4zRe/D7iCH9GojOpY9aNxIONJTMUmOe5mqMvRT7PPioCb7bKZlsM+?= =?us-ascii?Q?KKZ/cxR+ooaeA019BAQW19vGBXQULf5FnNmXb6Ek3UnFLVHrxVWp1oN/YI0R?= =?us-ascii?Q?CtoWXQfcjQ6jbGgD6yiEM5hX7WAL3iwKKF6N/G+dtHeAsl/ooIHRVL7U17fD?= =?us-ascii?Q?V3ViGVONCELk3r8Qw+Ggv4pKXbqAbPbRLd8/fBqZBj5fzEWoC3v3x1NOskoY?= =?us-ascii?Q?2l8N/9cb5VtY4qfFwJ5J20V0VwJ6mwAbkYih0K19UsAxNbSMOMFkjX23Nmgg?= =?us-ascii?Q?mpLp8D+AAQipI8w+eimB93cW4OEcXujJgBZRoft/Kjs972PZaBFf5PcRSK8r?= =?us-ascii?Q?C662RWZ5ZuHCe1XaCn0bRGawBtVU6/fsk8TVTCzpG1HiwZdLukSpvpgEK0bX?= =?us-ascii?Q?fodkYitIXLwDU3SWKKLoChatmN0xLfUocRHadKTfuXO8rgcP7WhOmgUliaDy?= =?us-ascii?Q?4IVvl4aM8LbnSyp9M+9GSyGJaIqElEA14XYTEb0Ruh9Pt0UyZyNubftZGNUc?= =?us-ascii?Q?UHrun6/lI+p3XNHJbp02vjV0PmOs6gblseyAr2+l?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e88ffef-7e96-43fb-313c-08db0e8ac2a3 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 12:55:33.9151 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yqQqxtpcTAWyLohnaBwAx/lkZCsQSy97eZfA1ZX9JHvTuwd+z46kKPTFFY0bmNkT+6CWSjQEXHedI+77k1dZ0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6648 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2/14/2023 1:51 PM, Gupta, Pankaj wrote: >=20 >>> ConvertPages: range 1000000 - 41AEFFF covers multiple entries >>> ConvertPages: range 1000000 - 41AEFFF covers multiple entries >>> Accepting all memory >>> Accepting all memory >>> Accepting all memory >>> Accepting all memory >>> EFI stub: ERROR: exit_boot() failed! >>> EFI stub: ERROR: efi_main() failed! >>> StartImage failed: Invalid Parameter >>> Thanks, >>> Pankaj >> >> 4 calls is telling me that "Accepting all memory" is somehow modifying >> the memory map each call, but that shouldn't be happening. You've >> confirmed that the body of the loop is getting skipped after the first >> call? >=20 > yes. This also changes the memory key every time. Below change solves=20 > the issue > and don't even get even the second invocation of "Accepting all memory"=20 > message. It seems "gBS->FreePool" changes the memory map every time? >=20 > +=C2=A0 //gBS->FreePool (AllDescMap);^M Adding the diff. diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c index 6391d1f775..df51c2c050 100644 --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c @@ -123,7 +123,7 @@ AcceptAllMemory ( } } - gBS->FreePool (AllDescMap); + //gBS->FreePool (AllDescMap);^M return Status; } >=20 > Thanks, > Pankaj >=20