From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.1742.1580857492566446372 for ; Tue, 04 Feb 2020 15:04:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PTgJlbEa; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580857491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k+x8QeczeCKIejBE8+3eGVweCFX+LTp/i9yoSEQvJLA=; b=PTgJlbEajHqi8VmDQ6xMLjzrXxLRqydrnw89iabKD/QoPwQ8QQZikLRl8disFslaMN3gmj FQpA/vyWL4iJ+sq+0Kgo06OHXVP9YuT4ScdEhx0FiqN4rcgyIpqxx+Xib998Al66kqt/S4 mktU+qapMjr8hCBsihSxTgPUB25QL+w= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-xWyba1aPPr-XDg76praAxw-1; Tue, 04 Feb 2020 18:04:41 -0500 Received: by mail-wr1-f69.google.com with SMTP id x15so138047wrl.15 for ; Tue, 04 Feb 2020 15:04:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rB1YmI0UFlduO8EnQOxPP/Jeqp0xp2XK5M9aII7Y2x0=; b=MDrRF9MRuM8/WRHyTa/mR03EKty91NX8Nr4kqzVNsRGDnBwjLYSyt0xIbCcp3Z7l/2 cIfCrPkkR4tKqiQ8TAVJJ/cjG5uATTviLz/TRZo5lHz3Y3LYKKR164aplUdPtOHvllUJ QtZh6kM5NFkTkt9o7YMy8NUFkpgeLS+nYC3TErnQ/UaCxbRtuk5zAJKxUIlWWcPft03U fpMH6kilD6/R1PU78vU+JpChvKikkIcapnQR8+mNOOrq/wPGtlz4IIVbZLOrK39ltCoC R+3Au8oJ+ZxwuOuIvshWuo4Ycdxqn0UK5FXBLBozBQiALdNMbeA3oIRPToKGUBBAMvSV GSPQ== X-Gm-Message-State: APjAAAWtv+IaU3j3ClGwAF/m85d0eBxJHFX8u7QW3PnBTpi02wNYW4OD V3e79Pbt9X/y1/tbLMctPDpC3GAtDT9vp0akUgepn9Q2khyYe+pfgGMzmjdKxmRtA/6Rj+hp1w0 PWfGUssLPwycCQQ== X-Received: by 2002:a1c:6645:: with SMTP id a66mr1391928wmc.121.1580857480260; Tue, 04 Feb 2020 15:04:40 -0800 (PST) X-Google-Smtp-Source: APXvYqyOnPiUrktl0G4rH7QB00Ju4Qr2kOZ8sWmrJuqDsY5p6xCTn/vxOm1cQJtt2OGajBbXBV+2fQ== X-Received: by 2002:a1c:6645:: with SMTP id a66mr1391912wmc.121.1580857480011; Tue, 04 Feb 2020 15:04:40 -0800 (PST) Return-Path: Received: from [192.168.1.35] (162.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.162]) by smtp.gmail.com with ESMTPSA id h13sm21123000wrw.54.2020.02.04.15.04.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Feb 2020 15:04:39 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions To: "Gao, Zhichao" , "devel@edk2.groups.io" Cc: "Ni, Ray" References: <20191219140932.25428-1-philmd@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> <692bf71f-dd33-d8db-914c-2867845434ac@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8E2@SHSMSX101.ccr.corp.intel.com> <2c83fb1c-3080-bd31-6408-fb29cb51de75@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 5 Feb 2020 00:04:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: xWyba1aPPr-XDg76praAxw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 1/31/20 6:31 AM, Gao, Zhichao wrote: > Hi, >=20 > I have tried with the commit. It pass the check. Good news, thanks for checking :) Is there anything else I should do to get this series applied? Thanks, Phil. >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Philippe Mathieu-Daud=C3=A9 >> Sent: Tuesday, January 21, 2020 7:24 PM >> To: Gao, Zhichao ; devel@edk2.groups.io >> Cc: Ni, Ray >> Subject: Re: [edk2-devel] [PATCH v2 0/2] ShellPkg: Document the use of >> EFI_INVALID_PARAMETER by two functions >> >> Hi Zhichao, >> >> On 1/7/20 8:37 AM, Gao, Zhichao wrote: >>>> -----Original Message----- >>>> From: Philippe Mathieu-Daud=C3=A9 [mailto:philmd@redhat.com] >>>> Sent: Tuesday, January 7, 2020 3:10 PM >>>> To: Gao, Zhichao ; devel@edk2.groups.io >>>> Cc: Ni, Ray >>>> Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of >>>> EFI_INVALID_PARAMETER by two functions >>>> >>>> On 1/7/20 8:01 AM, Gao, Zhichao wrote: >>>>>> -----Original Message----- >>>>>> From: Philippe Mathieu-Daude >>>>>> Sent: Thursday, December 19, 2019 10:10 PM >>>>>> To: devel@edk2.groups.io >>>>>> Cc: Ni, Ray ; Gao, Zhichao >>>>>> ; Philippe Mathieu-Daude >>>>>> Subject: [PATCH v2 0/2] ShellPkg: Document the use of >>>>>> EFI_INVALID_PARAMETER by two functions >>>>>> >>>>>> Complete the list of values the functios ParseCommandLineToArgs() >>>>>> and >>>>>> UpdateArgcArgv() can return. >>>>>> >>>>>> The documentation was found to be incomplete while reviewing BZ#239= 5: >>>>>> https://edk2.groups.io/g/devel/message/51512 >>>>>> >>>>>> v2: >>>>>> - Shortened patch #1 subject to fit 72 chars >>>>> >>>>> The subject should be less than 72 chars (do not include 72 chars). >>>> >>>> What is the rationale for this restriction? Some tool limitation? >>> >>> Yes. There is a patch check tool in BaseTools\Scripts\ PatchCheck.py. = And the >> patch #1 can't pass the check. >> >> Since the patch "BaseTools/PatchCheck.py: Ignore CR and LF characters i= n >> subject length" got merged as commit 2649a735b24, can you retry to merg= e this >> patch? >> >> Thanks, >> >> Phil. >> >> >>=20 >=20