From: "MohammedX Rehan" <mohammedx.rehan@intel.com>
To: devel@edk2.groups.io, kathappan.esakkithevar@intel.com,
zhichao.gao@intel.com, ray.ni@intel.com,
madhan.pethaiyan@intel.com
Cc: madhavix.thirupugal@intel.com,
MohammedX Rehan <mohammedx.rehan@intel.com>
Subject: [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure
Date: Tue, 15 Feb 2022 13:37:03 +0530 [thread overview]
Message-ID: <e11d98bfcb87a2e067d47354d65e26cbae0e27a9.1644912338.git.mohammedx.rehan@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3819
Ping GetTimerPeriod API returns sometime zero value when
StallCounter has smaller value than RttTimerTick (divide by zero)
which results some failure at ping UEFI shell command
Signed-off-by: MohammedX Rehan <mohammedx.rehan@intel.com>
---
ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
index ec1e0a188b..6a002b15e5 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
@@ -259,9 +259,11 @@ GetTimerPeriod (
EFI_EVENT TimerEvent;
UINT32 StallCounter;
EFI_TPL OldTpl;
+ UINT32 TimerPeriod;
RttTimerTick = 0;
StallCounter = 0;
+ TimerPeriod = 0;
Status = gBS->CreateEvent (
EVT_TIMER | EVT_NOTIFY_SIGNAL,
@@ -295,7 +297,12 @@ GetTimerPeriod (
gBS->SetTimer (TimerEvent, TimerCancel, 0);
gBS->CloseEvent (TimerEvent);
- return StallCounter / RttTimerTick;
+ TimerPeriod = StallCounter / RttTimerTick;
+ if (TimerPeriod != 0) {
+ return TimerPeriod;
+ } else {
+ return 1;
+ }
}
/**
--
2.30.0.windows.2
next reply other threads:[~2022-02-15 8:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 8:07 MohammedX Rehan [this message]
2022-02-15 8:09 ` [PATCH] ShellPkg: Fix Ping GetTimerPeriod API failure Gao, Zhichao
2022-02-16 6:34 ` Ni, Ray
-- strict thread matches above, loose matches on Subject: below --
2022-02-05 5:19 mohammedx.rehan
2022-02-10 2:46 ` Ni, Ray
2022-02-10 6:59 ` MohammedX Rehan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e11d98bfcb87a2e067d47354d65e26cbae0e27a9.1644912338.git.mohammedx.rehan@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox