From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A0A67D8118B for ; Thu, 21 Dec 2023 16:34:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=eJoZGQ5PuzZZg+puVaEL/5oI2FqW6ne0JgSvk1Op/z0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Authentication-Results-Original:Message-ID:Date:User-Agent:Subject:To:CC:References:From:In-Reply-To:MIME-Version:NoDisclaimer:Original-Authentication-Results:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703176485; v=1; b=HwXhAGUYPl+/DTbyYhakjlLpnEeuDhemk3kc6Z2uR/uWiqiBCtn/nf6we/Vrd2dHsBqWkFnd ctzEr/r32PwF1tpWcRJ6pzI5dH6/k4H2ZO0rFiBVUY8yaYXWueObBSJyJbb46PBseFSCjyjlaG4 gKWaDS4MWI/DgYj7i8WKAQgs= X-Received: by 127.0.0.2 with SMTP id S9gRYY7687511xp8A19TUeYm; Thu, 21 Dec 2023 08:34:45 -0800 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com (EUR05-DB8-obe.outbound.protection.outlook.com [40.107.20.75]) by mx.groups.io with SMTP id smtpd.web10.55483.1703176483643000307 for ; Thu, 21 Dec 2023 08:34:44 -0800 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Sxsm8CCnanQmzrC2tA/eb1pcODv2wnrr/4c3/IMn1NFR+Wk2uqkYS3Jy6DZrDNRWVqWh4l07gR0AkQuzm6u3eagchrhGVqEHulnEI7fczM8hU/XrokbWi0539601M1GGBUyD4KNCKrDkzoj0ksk0DtIS+rWczaeTkRFUw53Q1hwf6Gj2+T16+XghG6y/nWq7SS38nl4JgozT+05d1aeLnqltDYFxO+xcq0oFFc/rtuMAGqFUo4fwcVApJfAdNXUnOq2Xvr9NeOIaI81tyXovBt78JX/E8V3pIto8gVnbmCQwhMiJ3tJV7UBarpuCHBRXAMP7c8XtAq4JUyKa5GBKIQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0UTEdelZhixv9hReWnFPgm6WJH06YT7px7D4c2AhYaY=; b=X+/HbdTTp7hc2ejxaJQjC3kUlryK01Lm13K08FFnSKUE2XMEXLaUNXStRLGnKIBRqFNAf9bDpgMw94Xg0E90c5Ze36h7WDaniFdOwOD1vwN9arcBT70pGOFAp5y0P3eMqopYU9I+a4b/Gm7ayTuZgMlYfBEbM1H4Sdqb1wGEg0qI4qehZFTSLzOrmQzsxOaR6El+utlu5UeeGNakDgNS1U47kLCl7qOtNq5aEW84OG1QiZWiUWpxffZYut02Lc7BfZXg8RBzUcXvaDZD+YzSDKp6hASxhEDnafp2bzQxMRunou67l836gm2bsao9S/mM7oNwKqjTObxuDMEn2fs8UQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM7PR02CA0030.eurprd02.prod.outlook.com (2603:10a6:20b:100::40) by AM8PR08MB5778.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20; Thu, 21 Dec 2023 16:34:40 +0000 X-Received: from AM1PEPF000252DE.eurprd07.prod.outlook.com (2603:10a6:20b:100:cafe::13) by AM7PR02CA0030.outlook.office365.com (2603:10a6:20b:100::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.20 via Frontend Transport; Thu, 21 Dec 2023 16:34:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM1PEPF000252DE.mail.protection.outlook.com (10.167.16.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.14 via Frontend Transport; Thu, 21 Dec 2023 16:34:39 +0000 X-Received: ("Tessian outbound 20615a7e7970:v228"); Thu, 21 Dec 2023 16:34:39 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8aed5cd19f9d2a72 X-CR-MTA-TID: 64aa7808 X-Received: from c7420dbfcb8c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA446563-0C00-4A7A-8A39-22F3C1F97177.1; Thu, 21 Dec 2023 16:34:33 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7420dbfcb8c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Dec 2023 16:34:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lvdhgTLGf/UF1IDy0shmS8NuNFO1ZAiKLrtqp2IwLEc6FA1y2hqOB/0vApXytwf87MwaylkhbcSWpCSbwwhul4iB6sYIaOLvcpo0Vc7K7omDT7fQB2onXMwc+0fvfZowzhyeVV3mmZfPDldsFb5gLGE5XXLPcYZ3iOaqED0caMk2B6IJosXHc/pBgkCiRo8ncdangRYbL6Crz3jzjM2z4Hm9SR+6ehVxJtdnAQy1WIr3k/zAaIf1Tc2/lixaMLHrokU1VqbZ2KbrYAiTyCHAAbWEoaQXRsIwCqyTYgWQgrCAtldeXNvYzOq15KGa+qPyTme7z91lEWgeo3wwbR6Cdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0UTEdelZhixv9hReWnFPgm6WJH06YT7px7D4c2AhYaY=; b=nS/Ed9YCEMUrXKEdb1VUErMIgL4CBNyp/pvQEJ1JNH3djvRUbJFnIK5S8K1NyakJuZLNNJ1Pg5dYlR5Qd4XT6RzynLfX1RrmOC7kFkFyWISxLXj0pJoJX4ZSnV0nzg005ZTy/8x7Kv41vk7ixgFhz6OwMQd7qfNnrjNTCDcPyvCW+qqc1+nWPrDfdz5dLfTbG2+Xh+TEGdWHykikN+X2BMxPBPo2U3XaTQnXmZW5KB8PUTkOax4cz79a85YyqVvxjGK0utTi6X4/6yqREFcYBgZL99q2lV9oyRCNEaJnPNJD4UkvVtN7YQuEHoYgaCa5bmDGBlj455NNb95HDoSthw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU5PR08MB10734.eurprd08.prod.outlook.com (2603:10a6:10:526::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.18; Thu, 21 Dec 2023 16:34:31 +0000 X-Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::f36e:3882:2fce:d775%4]) with mapi id 15.20.7113.019; Thu, 21 Dec 2023 16:34:31 +0000 Message-ID: Date: Thu, 21 Dec 2023 16:34:28 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [Resend PATCH v5 0/4] DynamicTablesPkg: Adds WordIO and method invocation ability To: devel@edk2.groups.io, Abdul Lateef Attar CC: Abdul Lateef Attar , Pierre Gondois , "nd@arm.com" References: <17A2DD5CE37E2833.24485@groups.io> From: "Sami Mujawar" In-Reply-To: <17A2DD5CE37E2833.24485@groups.io> X-ClientProxiedBy: LO4P302CA0014.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c2::15) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU5PR08MB10734:EE_|AM1PEPF000252DE:EE_|AM8PR08MB5778:EE_ X-MS-Office365-Filtering-Correlation-Id: d242ff9a-022d-4cd1-f185-08dc0242ba83 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rPfa3TSl53NaOsxydH2DYn9D+ghKHgMgXnuy5xYgFvAmed0K8rKPdDyaebQlgx606AlbqyGJYKQ202H3jeOh2xtd5NjCYCFGKlN00vKmaUwZGno4ymYI5ySjQaH/zvYRwGqvG7SfISRTCHaK7ktUuY0IRxFSmrQOT7NyY2lfDTo6b1o1nDDbREcKgxcWpLuUyosGQSFW/NV76P8Mdq+5qbA5woT51eDFoC9fuSF9+cL4K87cy3/beBX7qnASKaBd0OTdCLZAbrwy7uGdRE2tAfV1C0X8si28P80Bd7AzEyQfT3ZKAOhA4eKdNO7OOq3aO613myaJ8ceY3Wtkuu/DQ/sYE4h6ZvFFGe2zZNT9J4JhuhBwAvyxl+GED1qAIBelHRT9iscViz23mnHvWH4u6xhxpS45LC/7q6zgFPdW+8YXbkJQ6NC18t10Dvw2rYiX5abK5EvIQs3giVSUlAK9suH/PKV+z5fZEgnThb93TalV2q+ykg9rYm/kKfcYjFaRs9IIkGs8M8RQjDIUe/qLzfuLAuCZzNV2IiFj1FzxvTIoZtYAlk5g6opATK6nCxSJvsGxXUSaXEz7GEbLcE5rbzUK4r+Q53gFZ2UH/CJudS4OZwxtHmvQGL5MAFQhZtrTWA3Wxng6ni7pvNfuM0PUkCMT75Z0M4/mjoB4ThwFE8M= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(346002)(366004)(376002)(39860400002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(31686004)(66899024)(6512007)(966005)(66556008)(4326008)(6486002)(5660300002)(6506007)(53546011)(66476007)(54906003)(66946007)(6916009)(8676002)(8936002)(83380400001)(26005)(44832011)(2616005)(316002)(478600001)(6666004)(36756003)(38100700002)(31696002)(2906002)(86362001)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10734 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 800fd1d6-6ffb-40bb-655d-08dc0242b55b X-Microsoft-Antispam-Message-Info: XNf/IwAjz+QmGVA8pmKEEPrsWvXt5oOEQJ8z1M0GyIomrWkQy7m1V/oM6f4IwDzmPK/JMDTxdnGqBTDYmraw6trr6ZRqaHwmH5yJfztMU4T4XcUNTL6QSpDgG+59fn/ROkPQNo1J8YV6zu37w7jpbcYhi5dSArRy1qEJkeJTFHfGiW3LdcWode55pEjU8pv56cISBr0JPEPf0rr/T+MHJjwsgUDES3AgUwuenIzDtoMJdI68WdXBty+MDy88M/ypiukrAG/rVOBk49xb5PfeqEQiON6JoQenik06Hdu9+NFeR24NIuk0YVuMgROjh0xZiSaXDoi388GiVDMupG4qLh1XZaDUapkQWLwL/zZkPejWghzaqEAZRyvwSzbx7wUnbe3mh7bsT6mgph+2WNaakDkPLY2QlQS4tjtT22aRg4YXy3vebhTyXhYSh6+3FiQtXZlXgad/Y33pMABT5mFu74j/cmZMLNWV9MED/6XRb3rw67uYiDGuc6SljTa7p+FmlE9njl6dE6nDm7OOZHpykQ8TlYon6R2u61QFg/8V8OEzIHVrMKMHA3VhNlrcdeXxpJ1xUlPeZ1UrMl0AxqXdf4Huwto82kPi9EDxgrOlB7YndvVkzNrB9J3fAd0677HgfSDVHkuMEO541CVpYY65LO87oQtctr3hMOf3MyRWQMMyREoaZp5mLcCIPMD+g4BYMC8PNu5960gsgILm321yORk6x4f+SLepXPQ2TWNeKfSdpb/w1bG0tOprTN8X7PCAwz5s+PmAoKfalAMbkT+Y5kiFosIwYfj0o6L71wcf5Ss= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 16:34:39.9605 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d242ff9a-022d-4cd1-f185-08dc0242ba83 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM1PEPF000252DE.eurprd07.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5778 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8meMcw2sEdUq4qpUuVPXv4knx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HwXhAGUY; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Abdul, Can you check if the patch 4/4 at=20 https://github.com/samimujawar/edk2/tree/REVIEW_2923_dynamictables_word_io_= method_invocation_v5=20 looks ok to you,=C2=A0 please? If you confim, I will apply the push label. Regards, Sami Mujawar On 21/12/2023 01:56 pm, Sami Mujawar via groups.io wrote: > Hi Abdul, > > Glad to see your contribution to the Dynamic Tables Framework. It=20 > would be great to hear how you are using this package. > > I have some minor comments for the last patch 4/4. If you can reply=20 > back, I will try to get the changes merged before the end of this week. > > Regards, > > Sami Mujawar > > On 20/12/2023 09:38 am, Abdul Lateef Attar wrote: >> From: Abdul Lateef Attar >> >> PR: https://github.com/tianocore/edk2/pull/5171/ >> >> V5: delta changes >> =C2=A0=C2=A0 Addressed review comments. >> V4: >> =C2=A0=C2=A0 Address Pierre's review comments. >> =C2=A0=C2=A0 Merged patch 4 & patch 5. >> =C2=A0=C2=A0 Also added parameter logic suggested by Pierre. >> V3: delta changes >> =C2=A0=C2=A0 CI fix and error handling for >> =C2=A0=C2=A0=C2=A0=C2=A0 DynamicTablesPkg: Adds API to generate a method= with ArgN. >> =C2=A0=C2=A0 Added new patch "DynamicTablesPkg: Adds wrapper API=20 >> AmlCodeGenMethodInvokeMethodArgn" >> V2: >> =C2=A0=C2=A0 Added new API to generate a method which >> =C2=A0=C2=A0 invokes another method with argument. >> V1: >> Code changes to >> Add API to generate word I/O ranges. >> Correct the parameter to generate word bus number. >> Corrects the function pointer typedef >> >> Cc: Pierre Gondois >> Cc: Sami Mujawar >> Cc: Abdul Lateef Attar >> >> Abdul Lateef Attar (4): >> =C2=A0=C2=A0 DynamicTablesPkg: AML Code generation for word I/O ranges >> =C2=A0=C2=A0 DynamicTablesPkg: Corrects AmlCodeGenRdWordBusNumber parame= ters >> =C2=A0=C2=A0 DynamicTablesPkg: Corrects function pointer typedef of >> =C2=A0=C2=A0=C2=A0=C2=A0 AML_PARSE_FUNCTION >> =C2=A0=C2=A0 DynamicTablesPkg: AML Code generation to invoke a method >> >> =C2=A0 .../Include/Library/AmlLib/AmlLib.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 187 +++++++++++++- >> =C2=A0 .../Common/AmlLib/CodeGen/AmlCodeGen.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 | 235 +++++++++++++++++- >> =C2=A0 .../AmlLib/CodeGen/AmlResourceDataCodeGen.c=C2=A0=C2=A0 |=C2=A0 9= 8 +++++++- >> =C2=A0 .../Library/Common/AmlLib/Parser/AmlParser.c=C2=A0 |=C2=A0=C2=A0 = 3 +- >> =C2=A0 4 files changed, 510 insertions(+), 13 deletions(-) >> > > >=20 > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112822): https://edk2.groups.io/g/devel/message/112822 Mute This Topic: https://groups.io/mt/103278517/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-