public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: caiyuqing379 <caiyuqing_hz@163.com>
To: "Sunil V L" <sunilvl@ventanamicro.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	 "libing1202@outlook.com" <libing1202@outlook.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension
Date: Mon, 15 Jan 2024 15:33:19 +0800 (GMT+08:00)	[thread overview]
Message-ID: <e11f1.4d5e.18d0c0a039b.Coremail.caiyuqing_hz@163.com> (raw)
In-Reply-To: <ZaS3cCjggThEsVMh@sunil-laptop>

[-- Attachment #1: Type: text/plain, Size: 2152 bytes --]

Hi, Sunil
Thanks for the suggestion, I'll keep the commit message up to date.


Thanks again!
Yuqing Cai
---- Replied Message ----
| From | Sunil V L<sunilvl@ventanamicro.com> |
| Date | 1/15/2024 12:41 |
| To | <caiyuqing_hz@163.com> |
| Cc | <devel@edk2.groups.io> ,
USER0FISH<libing1202@outlook.com> |
| Subject | Re: [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension |
On Sat, Jan 13, 2024 at 10:39:16AM +0800, caiyuqing_hz@163.com wrote:
From: caiyuqing379 <caiyuqing_hz@outlook.com>

Override Sstc extension and use SBI calls itself by default for RISC-V
Sophgo SG2042 platform.

Since the change disables CMO also (BIT 0) which is expected, could you
update the commit message to reflect it?

Otherwise,
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks,
Sunil
Cc: dahogn <dahogn@hotmail.com>
Cc: meng-cz <mengcz1126@gmail.com>
Cc: USER0FISH <libing1202@outlook.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Signed-off-by: caiyuqing379 <caiyuqing_hz@outlook.com>
---
Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc | 1 +
1 file changed, 1 insertion(+)

diff --git a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
index 3bbaeca16970..127182487126 100644
--- a/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
+++ b/Platform/Sophgo/SG2042_EVB_Board/SG2042.dsc
@@ -265,6 +265,7 @@
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1
gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
+  gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0xFFFFFFFFFFFFFFFC
gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
--
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113853): https://edk2.groups.io/g/devel/message/113853
Mute This Topic: https://groups.io/mt/103733215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6498 bytes --]

      reply	other threads:[~2024-01-16  5:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13  2:39 [edk2-devel] [PATCH v2 0/1] Sophgo/SG2042Pkg: Disable Sstc feature caiyuqing_hz
2024-01-13  2:39 ` [edk2-devel] [PATCH v2 1/1] Sophgo/SG2042Pkg: Override Sstc extension caiyuqing_hz
2024-01-15  4:41   ` Sunil V L
2024-01-15  7:33     ` caiyuqing379 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e11f1.4d5e.18d0c0a039b.Coremail.caiyuqing_hz@163.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox