Re: [edk2-devel] [PATCH v4 3/7] Platform/RaspberryPi: Split MMC register definitions

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/5/21 5:34 PM, Jeremy Linton wrote:
> The current MMC (really SDHCI) definitions are tied to the
> Arasan controller. As we intend to reuse the definitions lets
> make the base address configurable when the driver loads.
> 
> This assumes we won't ever want to run both the eMMC2
> and Arasan SDHCI controller at the same time.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
> ---
>  .../Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c    |  9 ++++-
>  .../Bcm283x/Include/IndustryStandard/Bcm2836Sdio.h | 42 ++++++++++++----------
>  2 files changed, 32 insertions(+), 19 deletions(-)
> 
> diff --git a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
> index 88e9126e35..c8fdfc193b 100644
> --- a/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
> +++ b/Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.c
> @@ -16,6 +16,7 @@ STATIC CARD_DETECT_STATE mCardDetectState = CardDetectRequired;
>  UINT32 LastExecutedCommand = (UINT32) -1;
>  
>  STATIC RASPBERRY_PI_FIRMWARE_PROTOCOL *mFwProtocol;
> +STATIC UINTN MmcHsBase;

I expect EDK2 style to ask for 'mMmcHsBase'.

With it:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>